feat: Re-emit messages from legacy namespace on new namespace #9
+92
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2 of sparkles, we switched to using a symbol to attach our event emitter to the global. This leads to blackholing of messages if we don't listen to the old emitter. In this PR, I'm consuming a new
legacymodule from our sparkles package to listen for messages on the old namespace. If a message is received, adeprecatedevent is emitted that a consumer can listen to and show a message. Then, the message is re-emitted on the new logger namespace.This will help us with gulpjs/gulp-cli#249