Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert options & yargs parser changes #257

Merged
merged 1 commit into from Mar 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 15 additions & 3 deletions index.js
Expand Up @@ -2,8 +2,9 @@

var fs = require('fs');
var path = require('path');
var log = require('gulplog');

var log = require('gulplog');
var yargs = require('yargs');
var Liftoff = require('liftoff');
var interpret = require('interpret');
var v8flags = require('v8flags');
Expand All @@ -12,7 +13,7 @@ var chalk = require('chalk');
var exit = require('./lib/shared/exit');
var tildify = require('./lib/shared/tildify');
var makeTitle = require('./lib/shared/make-title');
var parser = require('./lib/shared/options/parser');
var cliOptions = require('./lib/shared/options/cli-options');
var completion = require('./lib/shared/completion');
var cliVersion = require('./package.json').version;
var toConsole = require('./lib/shared/log/to-console');
Expand Down Expand Up @@ -52,7 +53,18 @@ var cli = new Liftoff({
},
});

var opts = parser.argv;
var usage =
'\n' + chalk.bold('Usage:') +
' gulp ' + chalk.blue('[options]') + ' tasks';

var parser = yargs
.help(false)
.version(false)
.detectLocale(false)
.usage(usage)
.options(cliOptions);

var opts = parser.parse();

cli.on('preload:before', function(name) {
log.info('Preloading external module:', chalk.magenta(name));
Expand Down
@@ -1,11 +1,6 @@
'use strict';

var chalk = require('chalk');
var yargs = require('yargs');

var usage =
'\n' + chalk.bold('Usage:') +
' gulp ' + chalk.blue('[options]') + ' tasks';

var options = {
help: {
Expand Down Expand Up @@ -121,8 +116,4 @@ var options = {
}
};

var parser = yargs
.help(false).version(false).detectLocale(false)
.usage(usage).options(options);

module.exports = parser;
module.exports = options;
4 changes: 3 additions & 1 deletion test/fixtures/logging.js
@@ -1,7 +1,9 @@
var log = require('gulplog');
var yargs = require('yargs');
var toConsole = require('../../lib/shared/log/to-console');
var cliOptions = require('../../lib/shared/options/cli-options');

var opts = require('../../lib/shared/options/parser').argv;
var opts = yargs.options(cliOptions).parse();

toConsole(log, opts);

Expand Down