feat!: Upgrade to Liftoff v5 and avoid merging flags/config/env #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sttk please review this. I've cherry-picked it into my translations prototype to ensure these changes work with the concept. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to Liftoff v5 and removes a bunch of the merging between flags, config, and the environment.
I've also decided that I don't want to merge the local config and home config, so this changes to find the first available config.
Notice that Liftoff v5 ensures that the
cwdis the directory where the gulpfile as specified in theconfigexists. Sincegulp.src/gulp.destare often used with relative paths, it is important that thecwdmatch the location of the gulpfile. This is what affected the majority of the test changes.TODO: