feat!: Define configFiles with an array to prioritize configs #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
force-pushed
the
phated/config-files-array
branch
from
7b42ef8
to
4bc795f
Compare
|
@sttk I'm going to merge this so I can make the release. Let me know if you notice anything and we can fix in another PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the
configFilesproperty to be defined as an array instead of an object. This makes it more verbose to specify multiple configFile lookups. The reason for this change is to have a defined ordering so the config overrides are applied in a guaranteed order.This has another benefit in that we'll attempt to locate and read all
configFilesand the users can do whatever they want with them.Still TODO: