Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add module for accessing legacy store #10

Merged
merged 2 commits into from Mar 23, 2024
Merged

feat: Add module for accessing legacy store #10

merged 2 commits into from Mar 23, 2024

Conversation

phated
Copy link
Member

@phated phated commented Mar 23, 2024

In #9, we switched to using a symbol to store the global emitter. However, this leads to blackholing of messages if we don't listen to the old emitter. In this PR, I've added a new module called legacy that packages can require to access the old namespace. This will be consumed in glogg to re-emit on the new namespace.

@phated phated requested a review from sttk March 23, 2024 21:25
@phated phated merged commit 8a5de25 into master Mar 23, 2024
15 checks passed
@phated phated deleted the phated/legacy branch March 23, 2024 21:32
phated added a commit that referenced this pull request Mar 23, 2024
chore: Combine tests into one file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant