-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-15947: fixed skipped_column error in Python #16164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this fix @wendycwong, but I must admit that I still don't understand why the old check is still in place.
h2o-py/tests/testdir_apis/Data_Manipulation/pyunit_h2oH2OFrame.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wendycwong .
57b323a
to
da7946f
Compare
…ntain only columns not skipped.
…H2O Frame and when import_file is loaded into H2O frame.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are green. LGTM. Thanks @wendycwong!
issue: #15947
The problem here is when called with h2o.H2OFrame, we did not take into account of skipped columns when trying to figure out the final column counts.
Fixed the bug and added Python test from Seb.
Fixed the bug in R and added R test.