-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push notif v2 #41
Open
jimlo7760
wants to merge
60
commits into
main
Choose a base branch
from
push_notif_V2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Push notif v2 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi reviewers,
I am Yanzhen from Push Notification team in HackRPI mobile.
This is a pull request to the push notification of the workshops. Specifically, the notification will be pushed to the user's phone at five minutes before the workshop starts. This function will be turned on automatically when the workshop page is loaded, unless the user clicks the "bell icon" which turns to "bell-off icon".
For me, I changed the file CalanderObject.js to implement this function and WorkShops.json for testing. For comprehensive test description and environment configuration, please review the file Components->Notification->setup.md.
Feel free to DM me on discord if you have any questions!
Thanks!
Yanzhen Lu