-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group #37484
Open
acwwat
wants to merge
2
commits into
hashicorp:main
Choose a base branch
from
acwwat:f-aws_bedrockagent_agent_action_group-add_function_schema_support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/L
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
service/bedrockagent
Issues and PRs that pertain to the bedrockagent service.
labels
May 13, 2024
terraform-aws-provider
bot
added
needs-triage
Waiting for first response or review from a maintainer.
external-maintainer
Contribution from a trusted external contributor.
labels
May 13, 2024
acwwat
force-pushed
the
f-aws_bedrockagent_agent_action_group-add_function_schema_support
branch
3 times, most recently
from
May 14, 2024 02:49
3233de7
to
7e7b002
Compare
acwwat
changed the title
[WIP] feat: Add function schema support to aws_bedrockagent_agent_action_group
feat: Add function schema support to aws_bedrockagent_agent_action_group
May 14, 2024
github-actions
bot
added
size/XL
Managed by automation to categorize the size of a PR.
documentation
Introduces or discusses updates to documentation.
and removed
size/L
Managed by automation to categorize the size of a PR.
labels
May 14, 2024
acwwat
force-pushed
the
f-aws_bedrockagent_agent_action_group-add_function_schema_support
branch
2 times, most recently
from
May 15, 2024 02:16
c61cd9a
to
3b9a6db
Compare
justinretzolk
added
enhancement
Requests to existing resources that expand the functionality or scope.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
May 16, 2024
acwwat
force-pushed
the
f-aws_bedrockagent_agent_action_group-add_function_schema_support
branch
from
May 20, 2024 23:04
3b9a6db
to
751bee7
Compare
acwwat
changed the title
feat: Add function schema support to aws_bedrockagent_agent_action_group
feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group
May 20, 2024
I was working on a separate branch to add return of control support but realized that I am not doing myself a favor. I've decided to just add the commit to this branch/PR so both features can go in with changes to the same set of files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
enhancement
Requests to existing resources that expand the functionality or scope.
external-maintainer
Contribution from a trusted external contributor.
service/bedrockagent
Issues and PRs that pertain to the bedrockagent service.
size/XL
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add support for function schema and return of control to the
aws_bedrockagent_agent_action_group
resource.The function schema change was a bit tricky as the
parameters
argument for thefunction
block is a map of objects (being the parameter detail). With help from one of the maintainers, we determined a way to define the schema properly. Consequently,parameters
is effectively a configuration block for each parameter, and what would've been the map key (and the parameter name) must now be defined using themap_block_key
argument within theparameters
block.Relations
Closes #37391
Closes #37087
References
Referred to FunctionSchema and ActionGroupExecutor for API specs.
Output from Acceptance Testing