Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group #37484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 13, 2024

Description

This PR is to add support for function schema and return of control to the aws_bedrockagent_agent_action_group resource.

The function schema change was a bit tricky as the parameters argument for the function block is a map of objects (being the parameter detail). With help from one of the maintainers, we determined a way to define the schema properly. Consequently, parameters is effectively a configuration block for each parameter, and what would've been the map key (and the parameter name) must now be defined using the map_block_key argument within the parameters block.

Relations

Closes #37391
Closes #37087

References

Referred to FunctionSchema and ActionGroupExecutor for API specs.

Output from Acceptance Testing

$ make testacc TESTS=TestAccBedrockAgentAgentActionGroup_ PKG=bedrockagent
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgentActionGroup_'  -timeout 360m
=== RUN   TestAccBedrockAgentAgentActionGroup_basic
=== PAUSE TestAccBedrockAgentAgentActionGroup_basic
=== RUN   TestAccBedrockAgentAgentActionGroup_s3APISchema
=== PAUSE TestAccBedrockAgentAgentActionGroup_s3APISchema
=== RUN   TestAccBedrockAgentAgentActionGroup_update
=== PAUSE TestAccBedrockAgentAgentActionGroup_update
=== RUN   TestAccBedrockAgentAgentActionGroup_functionSchema
=== PAUSE TestAccBedrockAgentAgentActionGroup_functionSchema
=== RUN   TestAccBedrockAgentAgentActionGroup_returnControl
=== PAUSE TestAccBedrockAgentAgentActionGroup_returnControl
=== CONT  TestAccBedrockAgentAgentActionGroup_basic
=== CONT  TestAccBedrockAgentAgentActionGroup_functionSchema
=== CONT  TestAccBedrockAgentAgentActionGroup_update
=== CONT  TestAccBedrockAgentAgentActionGroup_s3APISchema
=== CONT  TestAccBedrockAgentAgentActionGroup_returnControl
--- PASS: TestAccBedrockAgentAgentActionGroup_functionSchema (37.29s)
--- PASS: TestAccBedrockAgentAgentActionGroup_s3APISchema (42.76s)
--- PASS: TestAccBedrockAgentAgentActionGroup_returnControl (47.44s)
--- PASS: TestAccBedrockAgentAgentActionGroup_basic (53.90s)
--- PASS: TestAccBedrockAgentAgentActionGroup_update (77.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       77.876s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels May 13, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 13, 2024
@acwwat acwwat force-pushed the f-aws_bedrockagent_agent_action_group-add_function_schema_support branch 3 times, most recently from 3233de7 to 7e7b002 Compare May 14, 2024 02:49
@acwwat acwwat changed the title [WIP] feat: Add function schema support to aws_bedrockagent_agent_action_group feat: Add function schema support to aws_bedrockagent_agent_action_group May 14, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/L Managed by automation to categorize the size of a PR. labels May 14, 2024
@acwwat acwwat force-pushed the f-aws_bedrockagent_agent_action_group-add_function_schema_support branch 2 times, most recently from c61cd9a to 3b9a6db Compare May 15, 2024 02:16
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
@acwwat acwwat force-pushed the f-aws_bedrockagent_agent_action_group-add_function_schema_support branch from 3b9a6db to 751bee7 Compare May 20, 2024 23:04
@acwwat acwwat changed the title feat: Add function schema support to aws_bedrockagent_agent_action_group feat: Add function schema and return of control support to aws_bedrockagent_agent_action_group May 20, 2024
@acwwat
Copy link
Contributor Author

acwwat commented May 20, 2024

I was working on a separate branch to add return of control support but realized that I am not doing myself a favor. I've decided to just add the commit to this branch/PR so both features can go in with changes to the same set of files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants