Migrate `ipam` resources to AWS Go SDKv2 #37513

DanielRieske · 2024-05-14T21:49:55Z

Description

This PR migrates the ipam resources to AWS SDKv2.

Relations

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 1  -run=TestAccIPAM -timeout 360m
=== RUN   TestAccIPAM_byoipIPv6
    ipam_byoip_test.go:26: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccIPAM_byoipIPv6 (0.00s)
=== RUN   TestAccIPAMOrganizationAdminAccount_basic
    ipam_organization_admin_account_test.go:32: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccIPAMOrganizationAdminAccount_basic (0.70s)
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMPoolCIDRAllocation_disappears
=== PAUSE TestAccIPAMPoolCIDRAllocation_disappears
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPoolCIDRAllocation_multiple
=== PAUSE TestAccIPAMPoolCIDRAllocation_multiple
=== RUN   TestAccIPAMPoolCIDRAllocation_differentRegion
=== PAUSE TestAccIPAMPoolCIDRAllocation_differentRegion
=== RUN   TestAccIPAMPoolCIDR_basic
=== PAUSE TestAccIPAMPoolCIDR_basic
=== RUN   TestAccIPAMPoolCIDR_basicNetmaskLength
=== PAUSE TestAccIPAMPoolCIDR_basicNetmaskLength
=== RUN   TestAccIPAMPoolCIDR_disappears
=== PAUSE TestAccIPAMPoolCIDR_disappears
=== RUN   TestAccIPAMPoolCIDR_Disappears_ipam
=== PAUSE TestAccIPAMPoolCIDR_Disappears_ipam
=== RUN   TestAccIPAMPoolCIDRsDataSource_basic
=== PAUSE TestAccIPAMPoolCIDRsDataSource_basic
=== RUN   TestAccIPAMPoolDataSource_basic
=== PAUSE TestAccIPAMPoolDataSource_basic
=== RUN   TestAccIPAMPool_basic
=== PAUSE TestAccIPAMPool_basic
=== RUN   TestAccIPAMPool_disappears
=== PAUSE TestAccIPAMPool_disappears
=== RUN   TestAccIPAMPool_ipv6Basic
=== PAUSE TestAccIPAMPool_ipv6Basic
=== RUN   TestAccIPAMPool_ipv6Contiguous
=== PAUSE TestAccIPAMPool_ipv6Contiguous
=== RUN   TestAccIPAMPool_cascade
=== PAUSE TestAccIPAMPool_cascade
=== RUN   TestAccIPAMPool_tags
=== PAUSE TestAccIPAMPool_tags
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4Basic
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4Basic
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4Allocated
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4Allocated
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
=== RUN   TestAccIPAMResourceDiscovery_serial
=== PAUSE TestAccIPAMResourceDiscovery_serial
=== RUN   TestAccIPAMScope_basic
=== PAUSE TestAccIPAMScope_basic
=== RUN   TestAccIPAMScope_disappears
=== PAUSE TestAccIPAMScope_disappears
=== RUN   TestAccIPAMScope_tags
=== PAUSE TestAccIPAMScope_tags
=== RUN   TestAccIPAM_basic
=== PAUSE TestAccIPAM_basic
=== RUN   TestAccIPAM_disappears
=== PAUSE TestAccIPAM_disappears
=== RUN   TestAccIPAM_description
=== PAUSE TestAccIPAM_description
=== RUN   TestAccIPAM_operatingRegions
=== PAUSE TestAccIPAM_operatingRegions
=== RUN   TestAccIPAM_cascade
=== PAUSE TestAccIPAM_cascade
=== RUN   TestAccIPAM_tier
=== PAUSE TestAccIPAM_tier
=== RUN   TestAccIPAM_tags
=== PAUSE TestAccIPAM_tags
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Basic
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (85.88s)
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolsDataSource_empty (11.31s)
=== CONT  TestAccIPAM_tags
--- PASS: TestAccIPAM_tags (51.25s)
=== CONT  TestAccIPAM_tier
--- PASS: TestAccIPAM_tier (47.48s)
=== CONT  TestAccIPAM_cascade
--- PASS: TestAccIPAM_cascade (53.86s)
=== CONT  TestAccIPAM_operatingRegions
=== CONT  TestAccIPAM_description
--- PASS: TestAccIPAM_operatingRegions (78.43s)
--- PASS: TestAccIPAM_description (48.42s)
=== CONT  TestAccIPAM_disappears
--- PASS: TestAccIPAM_disappears (41.43s)
=== CONT  TestAccIPAM_basic
--- PASS: TestAccIPAM_basic (30.03s)
=== CONT  TestAccIPAMScope_tags
=== CONT  TestAccIPAMScope_disappears
--- PASS: TestAccIPAMScope_tags (80.53s)
--- PASS: TestAccIPAMScope_disappears (40.32s)
=== CONT  TestAccIPAMScope_basic
--- PASS: TestAccIPAMScope_basic (59.35s)
=== CONT  TestAccIPAMResourceDiscovery_serial
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/basic
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/disappears
    ipam_resource_discovery_association_test.go:103: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating IPAM Resource Discovery: operation error EC2: CreateIpamResourceDiscovery, https response error StatusCode: 400, RequestID: 049019fa-71b3-437e-9751-f45ecd63a0b4, api error ResourceLimitExceeded: You've reached the limit for resource discoveries. You have created 1 resource discoveries, and you are limited to 1.
        
          with aws_vpc_ipam_resource_discovery.test,
          on terraform_plugin_test.tf line 21, in resource "aws_vpc_ipam_resource_discovery" "test":
          21: resource "aws_vpc_ipam_resource_discovery" "test" {
        
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/tags
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/basic
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/modify
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/disappears
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/tags
--- FAIL: TestAccIPAMResourceDiscovery_serial (345.67s)
    --- FAIL: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation (140.47s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/basic (41.69s)
        --- FAIL: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/disappears (19.74s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/tags (79.04s)
    --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery (205.20s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/basic (29.34s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/modify (96.37s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/disappears (27.50s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/tags (51.98s)
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR (71.86s)
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4Allocated
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4Allocated (109.71s)
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4Basic
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4Basic (70.70s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR (81.97s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated (98.01s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic (81.70s)
=== CONT  TestAccIPAMPoolCIDRsDataSource_basic
--- PASS: TestAccIPAMPoolCIDRsDataSource_basic (98.76s)
=== CONT  TestAccIPAMPoolsDataSource_basic
--- PASS: TestAccIPAMPoolsDataSource_basic (70.81s)
=== CONT  TestAccIPAMPool_tags
--- PASS: TestAccIPAMPool_tags (82.90s)
=== CONT  TestAccIPAMPool_cascade
--- PASS: TestAccIPAMPool_cascade (67.62s)
=== CONT  TestAccIPAMPool_ipv6Contiguous
--- PASS: TestAccIPAMPool_ipv6Contiguous (56.08s)
=== CONT  TestAccIPAMPool_ipv6Basic
--- PASS: TestAccIPAMPool_ipv6Basic (53.58s)
=== CONT  TestAccIPAMPool_disappears
--- PASS: TestAccIPAMPool_disappears (58.60s)
=== CONT  TestAccIPAMPool_basic
--- PASS: TestAccIPAMPool_basic (72.76s)
=== CONT  TestAccIPAMPoolDataSource_basic
--- PASS: TestAccIPAMPoolDataSource_basic (51.97s)
=== CONT  TestAccIPAMPoolCIDRAllocation_differentRegion
--- PASS: TestAccIPAMPoolCIDRAllocation_differentRegion (97.63s)
=== CONT  TestAccIPAMPoolCIDR_Disappears_ipam
--- PASS: TestAccIPAMPoolCIDR_Disappears_ipam (97.15s)
=== CONT  TestAccIPAMPoolCIDR_disappears
--- PASS: TestAccIPAMPoolCIDR_disappears (75.88s)
=== CONT  TestAccIPAMPoolCIDR_basicNetmaskLength
--- PASS: TestAccIPAMPoolCIDR_basicNetmaskLength (98.11s)
=== CONT  TestAccIPAMPoolCIDR_basic
--- PASS: TestAccIPAMPoolCIDR_basic (78.19s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR (94.38s)
=== CONT  TestAccIPAMPoolCIDRAllocation_multiple
--- PASS: TestAccIPAMPoolCIDRAllocation_multiple (87.89s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== CONT  TestAccIPAMPoolCIDRAllocation_disappears
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (89.44s)
--- PASS: TestAccIPAMPoolCIDRAllocation_disappears (88.74s)
PASS
ok	  github.com/hashicorp/terraform-provider-aws/internal/service/ec2	2901.393s

github-actions · 2024-05-14T21:50:07Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions · 2024-05-14T21:50:26Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

# Conflicts: # internal/service/ec2/findv2.go # internal/service/ec2/statusv2.go # internal/service/ec2/waitv2.go

ewbankkit

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccIPAM' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccIPAM -timeout 720m
=== RUN   TestAccIPAM_byoipIPv6
    ipam_byoip_test.go:26: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccIPAM_byoipIPv6 (0.00s)
=== RUN   TestAccIPAMOrganizationAdminAccount_serial
=== PAUSE TestAccIPAMOrganizationAdminAccount_serial
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMPoolCIDRAllocation_disappears
=== PAUSE TestAccIPAMPoolCIDRAllocation_disappears
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
=== RUN   TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPoolCIDRAllocation_multiple
=== PAUSE TestAccIPAMPoolCIDRAllocation_multiple
=== RUN   TestAccIPAMPoolCIDRAllocation_differentRegion
=== PAUSE TestAccIPAMPoolCIDRAllocation_differentRegion
=== RUN   TestAccIPAMPoolCIDR_basic
=== PAUSE TestAccIPAMPoolCIDR_basic
=== RUN   TestAccIPAMPoolCIDR_basicNetmaskLength
=== PAUSE TestAccIPAMPoolCIDR_basicNetmaskLength
=== RUN   TestAccIPAMPoolCIDR_disappears
=== PAUSE TestAccIPAMPoolCIDR_disappears
=== RUN   TestAccIPAMPoolCIDR_Disappears_ipam
=== PAUSE TestAccIPAMPoolCIDR_Disappears_ipam
=== RUN   TestAccIPAMPoolCIDRsDataSource_basic
=== PAUSE TestAccIPAMPoolCIDRsDataSource_basic
=== RUN   TestAccIPAMPoolDataSource_basic
=== PAUSE TestAccIPAMPoolDataSource_basic
=== RUN   TestAccIPAMPool_basic
=== PAUSE TestAccIPAMPool_basic
=== RUN   TestAccIPAMPool_disappears
=== PAUSE TestAccIPAMPool_disappears
=== RUN   TestAccIPAMPool_ipv6Basic
=== PAUSE TestAccIPAMPool_ipv6Basic
=== RUN   TestAccIPAMPool_ipv6Contiguous
=== PAUSE TestAccIPAMPool_ipv6Contiguous
=== RUN   TestAccIPAMPool_cascade
=== PAUSE TestAccIPAMPool_cascade
=== RUN   TestAccIPAMPool_tags
=== PAUSE TestAccIPAMPool_tags
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
=== RUN   TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4Basic
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4Basic
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4Allocated
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4Allocated
=== RUN   TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
=== PAUSE TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
=== RUN   TestAccIPAMResourceDiscovery_serial
=== PAUSE TestAccIPAMResourceDiscovery_serial
=== RUN   TestAccIPAMScope_basic
=== PAUSE TestAccIPAMScope_basic
=== RUN   TestAccIPAMScope_disappears
=== PAUSE TestAccIPAMScope_disappears
=== RUN   TestAccIPAMScope_tags
=== PAUSE TestAccIPAMScope_tags
=== RUN   TestAccIPAM_basic
=== PAUSE TestAccIPAM_basic
=== RUN   TestAccIPAM_disappears
=== PAUSE TestAccIPAM_disappears
=== RUN   TestAccIPAM_description
=== PAUSE TestAccIPAM_description
=== RUN   TestAccIPAM_operatingRegions
=== PAUSE TestAccIPAM_operatingRegions
=== RUN   TestAccIPAM_cascade
=== PAUSE TestAccIPAM_cascade
=== RUN   TestAccIPAM_tier
=== PAUSE TestAccIPAM_tier
=== RUN   TestAccIPAM_tags
=== PAUSE TestAccIPAM_tags
=== CONT  TestAccIPAMOrganizationAdminAccount_serial
=== CONT  TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMOrganizationAdminAccount_serial/basic
=== CONT  TestAccIPAMScope_disappears
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4Basic
=== NAME  TestAccIPAMOrganizationAdminAccount_serial/basic
    ipam_organization_admin_account_test.go:49: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccIPAMOrganizationAdminAccount_serial/disappears
    ipam_organization_admin_account_test.go:91: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccIPAMOrganizationAdminAccount_serial (0.53s)
    --- SKIP: TestAccIPAMOrganizationAdminAccount_serial/basic (0.45s)
    --- SKIP: TestAccIPAMOrganizationAdminAccount_serial/disappears (0.08s)
=== CONT  TestAccIPAM_operatingRegions
--- PASS: TestAccIPAMScope_disappears (36.29s)
=== CONT  TestAccIPAM_tags
--- PASS: TestAccIPAM_operatingRegions (66.67s)
=== CONT  TestAccIPAM_tier
--- PASS: TestAccIPAMPoolsDataSource_basic (67.73s)
=== CONT  TestAccIPAM_cascade
--- PASS: TestAccIPAM_tags (41.60s)
=== CONT  TestAccIPAMPoolCIDR_Disappears_ipam
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4Basic (87.03s)
=== CONT  TestAccIPAMPool_disappears
--- PASS: TestAccIPAM_cascade (48.73s)
=== CONT  TestAccIPAMPool_basic
--- PASS: TestAccIPAM_tier (68.96s)
=== CONT  TestAccIPAMPoolDataSource_basic
--- PASS: TestAccIPAMPool_disappears (51.31s)
=== CONT  TestAccIPAMPoolCIDRsDataSource_basic
--- PASS: TestAccIPAMPoolCIDR_Disappears_ipam (82.18s)
=== CONT  TestAccIPAMPoolCIDRAllocation_multiple
--- PASS: TestAccIPAMPool_basic (50.76s)
=== CONT  TestAccIPAMPool_ipv6Basic
--- PASS: TestAccIPAMPoolDataSource_basic (50.90s)
=== CONT  TestAccIPAMPoolCIDR_disappears
--- PASS: TestAccIPAMPool_ipv6Basic (49.90s)
=== CONT  TestAccIPAMPoolCIDR_basicNetmaskLength
--- PASS: TestAccIPAMPoolCIDRsDataSource_basic (80.63s)
=== CONT  TestAccIPAMPool_tags
--- PASS: TestAccIPAMPoolCIDRAllocation_multiple (87.46s)
=== CONT  TestAccIPAMPoolCIDR_basic
--- PASS: TestAccIPAMPoolCIDR_disappears (79.26s)
=== CONT  TestAccIPAMPool_cascade
--- PASS: TestAccIPAMPool_tags (57.90s)
=== CONT  TestAccIPAMPoolCIDRAllocation_differentRegion
--- PASS: TestAccIPAMPoolCIDR_basic (69.34s)
=== CONT  TestAccIPAMPool_ipv6Contiguous
--- PASS: TestAccIPAMPoolCIDR_basicNetmaskLength (101.25s)
=== CONT  TestAccIPAM_disappears
--- PASS: TestAccIPAM_disappears (24.56s)
=== CONT  TestAccIPAM_description
--- PASS: TestAccIPAMPoolCIDRAllocation_differentRegion (69.70s)
=== CONT  TestAccIPAM_basic
--- PASS: TestAccIPAMPool_ipv6Contiguous (50.16s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated
--- PASS: TestAccIPAMPool_cascade (103.65s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic
--- PASS: TestAccIPAM_basic (31.03s)
=== CONT  TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR
--- PASS: TestAccIPAM_description (46.10s)
=== CONT  TestAccIPAMScope_tags
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4DisallowedCIDR (59.09s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4Allocated (70.07s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR
--- PASS: TestAccIPAMPreviewNextCIDRDataSource_ipv4Basic (67.30s)
=== CONT  TestAccIPAMResourceDiscovery_serial
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/basic        
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/modify
--- PASS: TestAccIPAMScope_tags (57.24s)
=== CONT  TestAccIPAMScope_basic
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/disappears
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/tags
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/basic
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/disappears
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4DisallowedCIDR (82.66s)
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR
--- PASS: TestAccIPAMScope_basic (51.03s)
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (61.16s)
=== CONT  TestAccIPAMPoolCIDRAllocation_disappears
--- PASS: TestAccIPAMPoolsDataSource_empty (8.67s)
=== CONT  TestAccIPAMPoolCIDRAllocation_ipv4Basic
=== RUN   TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/tags
--- PASS: TestAccIPAMResourceDiscovery_serial (292.30s)
    --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation (131.77s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/disappears (41.90s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/tags (52.24s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscoveryAssociation/basic (37.64s)
    --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery (160.53s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/basic (23.94s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/modify (73.87s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/disappears (23.01s)
        --- PASS: TestAccIPAMResourceDiscovery_serial/ResourceDiscovery/tags (39.70s)
=== CONT  TestAccIPAMPreviewNextCIDR_ipv4Allocated
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4DisallowedCIDR (61.93s)
--- PASS: TestAccIPAMPoolCIDRAllocation_disappears (62.18s)
--- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (81.68s)
--- PASS: TestAccIPAMPreviewNextCIDR_ipv4Allocated (91.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	622.678s

ewbankkit · 2024-05-21T16:28:48Z

@DanielRieske Thanks for the contribution 🎉 👏.

github-actions · 2024-05-24T00:08:53Z

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

DanielRieske added 9 commits May 14, 2024 19:11

feat: initial commit

1d04bee

feat: migrated ipam_pool_cidr

bcaaf70

feat: migrated ipam_pool

0b26994

feat: migrated ipam_preview_next_cidr

9f68167

feat: migrated ipam_resource_discovery_association

88ec2d7

feat: migrated ipam_resource_discovery

c868efb

feat: migrated ipam_scope

54e80e4

feat: migrated ipam_test

7afef99

feat: migrated ipam_byoip

9908278

terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 14, 2024

DanielRieske added 8 commits May 14, 2024 23:56

Merge branch 'main' into f/migrate-ipam-sdkv2

f463a78

chore: run make cleantidy

4ae4aa8

fix: remove unused functions

ff98f61

fix: set tags in ipam_pool

af0a29c

chore: remove unnecessary newline

ab2e485

Merge branch 'main' into f/migrate-ipam-sdkv2

01d904b

chore: run make gen

ba2c22d

chore: added newline

abdf12a

justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024

DanielRieske and others added 3 commits May 21, 2024 01:47

Merge branch 'main' into f/migrate-ipam-sdkv2

de837ac

feat: reduced visibility

fdc3414

Merge branch 'main' into HEAD

19d843c

# Conflicts: # internal/service/ec2/findv2.go # internal/service/ec2/statusv2.go # internal/service/ec2/waitv2.go

ewbankkit self-assigned this May 21, 2024

terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 21, 2024

ewbankkit added 3 commits May 21, 2024 10:03

ipam: Reduce visibility -- finders etc.

c7a5f8d

ipam: Reduce visibility -- resources and data sources.

c815ab8

ipam: Fix sweepers.

c6cb9bd

ewbankkit reviewed May 21, 2024

View reviewed changes

ewbankkit approved these changes May 21, 2024

View reviewed changes

ewbankkit merged commit d5cdfff into hashicorp:main May 21, 2024
35 checks passed

github-actions bot added this to the v5.51.0 milestone May 21, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate `ipam` resources to AWS Go SDKv2 #37513

Migrate `ipam` resources to AWS Go SDKv2 #37513

DanielRieske commented May 14, 2024 •

edited

github-actions bot commented May 14, 2024

github-actions bot commented May 14, 2024

ewbankkit left a comment

ewbankkit commented May 21, 2024

github-actions bot commented May 24, 2024

Migrate ipam resources to AWS Go SDKv2 #37513

Migrate ipam resources to AWS Go SDKv2 #37513

Conversation

DanielRieske commented May 14, 2024 • edited

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented May 14, 2024

Community Note

github-actions bot commented May 14, 2024

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented May 21, 2024

github-actions bot commented May 24, 2024

Migrate `ipam` resources to AWS Go SDKv2 #37513

Migrate `ipam` resources to AWS Go SDKv2 #37513

DanielRieske commented May 14, 2024 •

edited