add aws_appfabric_appbundle resource #37542

walkoaw · 2024-05-15T17:13:07Z

Description

This PR adds a resource for aws_appfabric_appbundle

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccAppFabricAppBundle PKG=appfabric                                                            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.0 test ./internal/service/appfabric/... -v -count 1 -parallel 20 -run='TestAccAppFabricAppBundle'  -timeout 360m
=== RUN   TestAccAppFabricAppBundle_basic
=== PAUSE TestAccAppFabricAppBundle_basic
=== RUN   TestAccAppFabricAppBundle_disappears
=== PAUSE TestAccAppFabricAppBundle_disappears
=== CONT  TestAccAppFabricAppBundle_basic
=== CONT  TestAccAppFabricAppBundle_disappears
--- PASS: TestAccAppFabricAppBundle_disappears (12.62s)
--- PASS: TestAccAppFabricAppBundle_basic (15.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appfabric  19.935s```

github-actions · 2024-05-15T17:13:18Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions

Welcome @walkoaw 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

meetreks

Good Code, well done. Some minor edits required.

Also -- need 2 more files one is for change log and another for documentation - you can check the contributor guide for the same.

meetreks · 2024-05-18T15:02:19Z

internal/service/appfabric/app_bundle.go

+	"github.com/hashicorp/terraform-provider-aws/names"
+)
+
+func newResourceAppBundle(_ context.Context) (resource.ResourceWithConfigure, error) {


Please add framework @frameworkresource so that service gen can pick it up.

meetreks · 2024-05-18T15:03:01Z

internal/service/appfabric/app_bundle.go

+	resp.Diagnostics.Append(resp.State.Set(ctx, &state)...)
+}
+
+func (r *resourceAppBundle) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {


Add NoOps marker

meetreks · 2024-05-18T15:09:12Z

internal/service/appfabric/app_bundle_test.go

+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck: func() {
+			acctest.PreCheck(ctx, t)
+			testAccPreCheck(ctx, t)


I dont understand this check, usually we run a precheck like this
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, names.servicendpointID)
},

meetreks · 2024-05-18T15:11:17Z

internal/service/appfabric/app_bundle_test.go

+			{
+				ResourceName:      resourceName,
+				ImportState:       true,
+				ImportStateIdFunc: testAccAppBundleImportStateIDFunc(ctx, resourceName),


What is this test trying to do? I guess we can ignore this test

meetreks · 2024-05-18T15:13:26Z

internal/service/appfabric/app_bundle_test.go

+	}
+}
+`)
+}


Add one more test called _full and ensure you can pass customer_managed_key_identifier and also ensure all fields are returned in the output. Idea is _basic test is too check minimum and _full test should check all fields possible (even optional fields)

There are no required fields, so I just had :
testAccCheckAppBundleExists(ctx, resourceName, &appbundle),

Could _basic be deleted altogether?

meetreks · 2024-05-18T15:15:18Z

internal/service/appfabric/service_package_gen.go

@@ -19,7 +19,15 @@ func (p *servicePackage) FrameworkDataSources(ctx context.Context) []*types.Serv
 }

 func (p *servicePackage) FrameworkResources(ctx context.Context) []*types.ServicePackageFrameworkResource {
-	return []*types.ServicePackageFrameworkResource{}
+	return []*types.ServicePackageFrameworkResource{


is this auto generated?

I believe it was. Should it be deleted?

github-actions · 2024-05-29T20:00:49Z

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

…-aws

walkoaw · 2024-05-29T21:08:20Z

All comments have been addressed and documentation has been added.

meetreks

Looks good . Some minor edits required

As you have an optional field like "customer_managed_key_identifier": schema.StringAttribute{ Optional: true, }, then you need a test for the same.
You need a couple of additional tests for tags.

kaitheal and others added 3 commits May 14, 2024 17:16

adding all files from gitlab

8eee0d4

AppBundle Tests Pass

1097acf

Final

a44bd4c

terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 15, 2024

github-actions bot reviewed May 15, 2024

View reviewed changes

All comments removed

233815f

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024

meetreks reviewed May 18, 2024

View reviewed changes

kaitheal added 2 commits May 29, 2024 14:24

added framework resource and no op

d9c19d0

added framework resource commented out

7ffcb49

kaitheal and others added 9 commits May 29, 2024 15:10

adding endpointID

c4a4f55

added precheck to other functions

cdd2ebf

delete basic

05ed84d

delete precheck function

f89fe1f

added full test

7dc7a30

adding changelog

9ab3ede

Update Tests, Added Documentation

9ac84ee

Merge branch 'main' of https://github.com/kaitheal/terraform-provider…

43d8992

…-aws

All comments addressed

804a8a2

meetreks approved these changes May 31, 2024

View reviewed changes

Added 3 tests: 1 for customer_managed_key and 2 for tags

7197927

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add aws_appfabric_appbundle resource #37542

add aws_appfabric_appbundle resource #37542

walkoaw commented May 15, 2024

github-actions bot commented May 15, 2024

github-actions bot left a comment

meetreks left a comment

meetreks May 18, 2024

meetreks May 18, 2024

meetreks May 18, 2024

meetreks May 18, 2024

meetreks May 18, 2024

kaitheal May 29, 2024

kaitheal May 29, 2024

meetreks May 18, 2024

walkoaw May 29, 2024

github-actions bot commented May 29, 2024

walkoaw commented May 29, 2024

meetreks left a comment

add aws_appfabric_appbundle resource #37542

Are you sure you want to change the base?

add aws_appfabric_appbundle resource #37542

Conversation

walkoaw commented May 15, 2024

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented May 15, 2024

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

meetreks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 29, 2024

walkoaw commented May 29, 2024

meetreks left a comment

Choose a reason for hiding this comment