Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestreaminfluxdb service #37574

Closed
wants to merge 2 commits into from
Closed

Add timestreaminfluxdb service #37574

wants to merge 2 commits into from

Conversation

trevorbonas
Copy link
Contributor

Description

  • The timestreaminfluxdb service client has been added.

Relations

Relates #36398

References

Output from Acceptance Testing

N/A

trevorbonas and others added 2 commits May 16, 2024 16:22
@trevorbonas
Add TimestreamInfluxDB service client
d4989a1 
<!---
See what makes a good Pull Request at: https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/
--->
### Description
<!---
Please provide a helpful description of what change this pull request will introduce.
--->
- The `timestreaminfluxdb` service client has been added.


### Relations
<!---
If your pull request fully resolves and should automatically close the linked issue, use Closes. Otherwise, use Relates.

For Example:

Relates #0000
or 
Closes #0000
--->

Relates hashicorp#36398

### References
<!---
Optionally, provide any helpful references that may help the reviewer(s).
--->

- [Amazon Timestream for InfluxDB docs](https://docs.aws.amazon.com/timestream/latest/developerguide/timestream-for-influxdb.html).
- [AWS SDK Go V2 TimestreamInfluxDB documentation](https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/timestreaminfluxdb).

### Output from Acceptance Testing
<!--
Replace TestAccXXX with a pattern that matches the tests affected by this PR.

Replace ec2 with the service package corresponding to your tests.

For more information on the `-run` flag, see the `go test` documentation at https://tip.golang.org/cmd/go/#hdr-Testing_flags.
-->

N/A
@trevorbonas
Merge branch 'main' of github.com:hashicorp/terraform-provider-aws in…
b434d7d 
…to f-timestreaminfluxdb-service
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. linter Pertains to changes to or issues with the various linters. sweeper Pertains to changes to or issues with the sweeper. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. github_actions Pull requests that update Github_actions code labels May 16, 2024
@github-actions GitHub Actions
Copy link

Hey @trevorbonas 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 16, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

github-actions[bot]
github-actions bot reviewed May 16, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @trevorbonas 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@trevorbonas
Copy link
Contributor Author

trevorbonas commented May 17, 2024 •
edited

Per the documentation, this simply adds the timestreaminfluxdb service client without any resources:

Before new resources are submitted, please raise a separate pull request containing just the new AWS SDK for Go service client.

Acceptance test output is omitted as no acceptance tests have been created for the timestreaminfluxdb service.

This PR originates from an organization and "Allow edits from maintainers" cannot be enabled.

@justinretzolk justinretzolk added new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2024
@johnsonaj johnsonaj self-assigned this May 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 28, 2024
@johnsonaj johnsonaj mentioned this pull request May 28, 2024
Merged
@johnsonaj
Copy link
Contributor

@trevorbonas thank you for your contribution! 🎉

I merged your PR into one that I could edit; additional changes were needed.

@trevorbonas trevorbonas deleted the f-timestreaminfluxdb-service branch May 28, 2024 21:42
@trevorbonas
Copy link
Contributor Author

I am working on the aws_timestreaminfluxdb_db_instance resource and will provide updates in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees

@johnsonaj johnsonaj

Labels
generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. new-service Introduces a new service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trevorbonas @johnsonaj @justinretzolk