Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix crash during read due to key-only tags in aws_lightsail_instance #37587

Merged
merged 6 commits into from
May 24, 2024
Merged

fix: Fix crash during read due to key-only tags in aws_lightsail_instance #37587

merged 6 commits into from
May 24, 2024
+167 −6

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 19, 2024 •
edited

Description

This PR is to fix a crash with the aws_lightsail_instance resource when it reads a Lightsail instance that has a key-only tag (i.e. it has no value). This issue also affects other operations such as import and update.

Updated: Thanks to @johnsonaj's help, the issue mentioned below is now fixed.

It looks like somehow these key-only tags are not mapped to a TagData with a nil value, but rather nil itself. By adding a nil check in the ResolveDuplicates function the problem seems to be fixed however. However, the provider seems to be reading the instance before the tag updates when there is a key-only tag, so the state is always one update behind. I have having trouble figuring out why there's a difference in sequence at the moment.

Relations

Closes #37470
Closes #35727
Closes #32430

References

n/a

Output from Acceptance Testing

$ TF_ACC=1 go1.22.2 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run=TestAccLightsailInstance_
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_keyOnlyTags
=== PAUSE TestAccLightsailInstance_keyOnlyTags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_availabilityZone
    instance_test.go:343: skipping test; environment variable TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE must be set. Usage: The availability zone that is outside the providers current region.
--- SKIP: TestAccLightsailInstance_availabilityZone (0.00s)
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstance_basic
=== CONT  TestAccLightsailInstance_IPAddressType
=== CONT  TestAccLightsailInstance_tags
=== CONT  TestAccLightsailInstance_name
=== CONT  TestAccLightsailInstance_keyOnlyTags
=== CONT  TestAccLightsailInstance_addOn
=== CONT  TestAccLightsailInstance_disappears
--- PASS: TestAccLightsailInstance_disappears (52.56s)
--- PASS: TestAccLightsailInstance_basic (53.05s)
--- PASS: TestAccLightsailInstance_tags (70.02s)
--- PASS: TestAccLightsailInstance_keyOnlyTags (70.34s)
--- PASS: TestAccLightsailInstance_IPAddressType (75.77s)
--- PASS: TestAccLightsailInstance_name (144.72s)
--- PASS: TestAccLightsailInstance_addOn (248.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  248.935s
$ TF_ACC=1 go1.22.2 test ./internal/tags/... -v -count 1 -parallel 20 -run='TestKeyValueTags' -timeout 360m
=== RUN   TestKeyValueTagsDefaultConfigGetTags
=== PAUSE TestKeyValueTagsDefaultConfigGetTags
=== RUN   TestKeyValueTagsDefaultConfigMergeTags
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual
=== RUN   TestKeyValueTagsIgnoreAWS
=== PAUSE TestKeyValueTagsIgnoreAWS
=== RUN   TestKeyValueTagsIgnoreConfig
=== PAUSE TestKeyValueTagsIgnoreConfig
=== RUN   TestKeyValueTagsIgnoreElasticbeanstalk
=== PAUSE TestKeyValueTagsIgnoreElasticbeanstalk
=== RUN   TestKeyValueTagsIgnorePrefixes
=== PAUSE TestKeyValueTagsIgnorePrefixes
=== RUN   TestKeyValueTagsIgnoreSystem
=== PAUSE TestKeyValueTagsIgnoreSystem
=== RUN   TestKeyValueTagsIgnore
=== PAUSE TestKeyValueTagsIgnore
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue
=== RUN   TestKeyValueTagsKeyAdditionalStringValue
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue
=== RUN   TestKeyValueTagsKeyExists
=== PAUSE TestKeyValueTagsKeyExists
=== RUN   TestKeyValueTagsKeyTagData
=== PAUSE TestKeyValueTagsKeyTagData
=== RUN   TestKeyValueTagsKeyValues
=== PAUSE TestKeyValueTagsKeyValues
=== RUN   TestKeyValueTagsKeys
=== PAUSE TestKeyValueTagsKeys
=== RUN   TestKeyValueTagsMap
=== PAUSE TestKeyValueTagsMap
=== RUN   TestKeyValueTagsMerge
=== PAUSE TestKeyValueTagsMerge
=== RUN   TestKeyValueTagsOnly
=== PAUSE TestKeyValueTagsOnly
=== RUN   TestKeyValueTagsRemoved
=== PAUSE TestKeyValueTagsRemoved
=== RUN   TestKeyValueTagsUpdated
=== PAUSE TestKeyValueTagsUpdated
=== RUN   TestKeyValueTagsChunks
=== PAUSE TestKeyValueTagsChunks
=== RUN   TestKeyValueTagsContainsAll
=== PAUSE TestKeyValueTagsContainsAll
=== RUN   TestKeyValueTagsEqual
=== PAUSE TestKeyValueTagsEqual
=== RUN   TestKeyValueTagsHash
=== PAUSE TestKeyValueTagsHash
=== RUN   TestKeyValueTagsRemoveDefaultConfig
=== PAUSE TestKeyValueTagsRemoveDefaultConfig
=== RUN   TestKeyValueTagsURLEncode
=== PAUSE TestKeyValueTagsURLEncode
=== RUN   TestKeyValueTagsURLQueryString
=== PAUSE TestKeyValueTagsURLQueryString
=== RUN   TestKeyValueTagsString
=== PAUSE TestKeyValueTagsString
=== CONT  TestKeyValueTagsDefaultConfigGetTags
=== CONT  TestKeyValueTagsKeys
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual
=== CONT  TestKeyValueTagsIgnoreSystem
=== CONT  TestKeyValueTagsDefaultConfigMergeTags
=== RUN   TestKeyValueTagsIgnoreSystem/empty
=== PAUSE TestKeyValueTagsIgnoreSystem/empty
=== CONT  TestKeyValueTagsIgnorePrefixes
=== CONT  TestKeyValueTagsIgnoreElasticbeanstalk
=== CONT  TestKeyValueTagsIgnoreConfig
=== CONT  TestKeyValueTagsIgnoreAWS
=== RUN   TestKeyValueTagsIgnoreElasticbeanstalk/empty
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/empty_config
=== RUN   TestKeyValueTagsIgnoreConfig/empty_config
=== PAUSE TestKeyValueTagsIgnoreElasticbeanstalk/empty
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/empty_config
=== CONT  TestKeyValueTagsKeyExists
=== RUN   TestKeyValueTagsIgnoreElasticbeanstalk/all
=== PAUSE TestKeyValueTagsIgnoreConfig/empty_config
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/no_config
=== PAUSE TestKeyValueTagsIgnoreElasticbeanstalk/all
=== RUN   TestKeyValueTagsKeyExists/empty
=== RUN   TestKeyValueTagsIgnoreConfig/no_config
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/no_config
=== RUN   TestKeyValueTagsIgnoreElasticbeanstalk/mixed
=== PAUSE TestKeyValueTagsIgnoreConfig/no_config
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/empty_tags
=== RUN   TestKeyValueTagsIgnoreConfig/no_tags
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/empty_tags
=== CONT  TestKeyValueTagsContainsAll
=== PAUSE TestKeyValueTagsIgnoreElasticbeanstalk/mixed
=== PAUSE TestKeyValueTagsIgnoreConfig/no_tags
=== PAUSE TestKeyValueTagsKeyExists/empty
=== CONT  TestKeyValueTagsString
=== RUN   TestKeyValueTagsContainsAll/empty
=== RUN   TestKeyValueTagsIgnoreElasticbeanstalk/none
=== RUN   TestKeyValueTagsString/empty
=== CONT  TestKeyValueTagsURLQueryString
=== CONT  TestKeyValueTagsURLEncode
=== RUN   TestKeyValueTagsIgnoreConfig/keys_all_matching
=== PAUSE TestKeyValueTagsString/empty
=== PAUSE TestKeyValueTagsContainsAll/empty
=== CONT  TestKeyValueTagsRemoveDefaultConfig
=== PAUSE TestKeyValueTagsIgnoreConfig/keys_all_matching
=== CONT  TestKeyValueTagsKeyTagData
=== CONT  TestKeyValueTagsHash
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue
=== CONT  TestKeyValueTagsEqual
=== RUN   TestKeyValueTagsDefaultConfigGetTags/empty_config
=== PAUSE TestKeyValueTagsDefaultConfigGetTags/empty_config
=== CONT  TestKeyValueTagsKeyValues
=== RUN   TestKeyValueTagsKeys/empty_map_string_interface
=== PAUSE TestKeyValueTagsKeys/empty_map_string_interface
=== RUN   TestKeyValueTagsIgnoreSystem/all
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/empty_config
=== PAUSE TestKeyValueTagsIgnoreSystem/all
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/empty_config
=== RUN   TestKeyValueTagsIgnoreSystem/mixed
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/no_config
=== PAUSE TestKeyValueTagsIgnoreSystem/mixed
=== RUN   TestKeyValueTagsKeyExists/non-existent
=== RUN   TestKeyValueTagsIgnoreConfig/keys_some_matching
=== RUN   TestKeyValueTagsIgnoreSystem/none
=== RUN   TestKeyValueTagsRemoveDefaultConfig/empty_config
=== PAUSE TestKeyValueTagsKeyExists/non-existent
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/empty_config
=== RUN   TestKeyValueTagsRemoveDefaultConfig/no_config
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/no_config
=== RUN   TestKeyValueTagsIgnoreAWS/empty
=== RUN   TestKeyValueTagsKeyTagData/empty
=== PAUSE TestKeyValueTagsIgnoreSystem/none
=== PAUSE TestKeyValueTagsIgnoreAWS/empty
=== PAUSE TestKeyValueTagsKeyTagData/empty
=== RUN   TestKeyValueTagsDefaultConfigGetTags/nil_config
=== CONT  TestKeyValueTagsKeyAdditionalStringValue
=== RUN   TestKeyValueTagsKeyValues/empty
=== PAUSE TestKeyValueTagsDefaultConfigGetTags/nil_config
=== RUN   TestKeyValueTagsIgnorePrefixes/empty
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/no_config
=== PAUSE TestKeyValueTagsIgnorePrefixes/empty
=== PAUSE TestKeyValueTagsKeyValues/empty
=== RUN   TestKeyValueTagsKeyExists/matching_with_string_value
=== RUN   TestKeyValueTagsKeyTagData/non-existent
=== PAUSE TestKeyValueTagsKeyExists/matching_with_string_value
=== PAUSE TestKeyValueTagsKeyTagData/non-existent
=== RUN   TestKeyValueTagsString/no_value
=== PAUSE TestKeyValueTagsString/no_value
=== RUN   TestKeyValueTagsContainsAll/source_empty
=== PAUSE TestKeyValueTagsContainsAll/source_empty
=== PAUSE TestKeyValueTagsIgnoreConfig/keys_some_matching
=== RUN   TestKeyValueTagsContainsAll/target_empty
=== RUN   TestKeyValueTagsIgnorePrefixes/all_exact
=== PAUSE TestKeyValueTagsIgnorePrefixes/all_exact
=== PAUSE TestKeyValueTagsContainsAll/target_empty
=== RUN   TestKeyValueTagsHash/empty
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/empty
=== RUN   TestKeyValueTagsURLQueryString/empty
=== RUN   TestKeyValueTagsURLEncode/empty
=== PAUSE TestKeyValueTagsIgnoreElasticbeanstalk/none
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/no_tags
=== RUN   TestKeyValueTagsEqual/nil
=== RUN   TestKeyValueTagsDefaultConfigGetTags/with_Tags_config
=== RUN   TestKeyValueTagsRemoveDefaultConfig/no_tags
=== RUN   TestKeyValueTagsContainsAll/nil_value_matches
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/no_tags
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/empty
=== RUN   TestKeyValueTagsIgnoreAWS/all
=== PAUSE TestKeyValueTagsContainsAll/nil_value_matches
=== RUN   TestKeyValueTagsKeys/empty_map_string_stringPointer
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/non-existent_key
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/no_tags
=== PAUSE TestKeyValueTagsKeys/empty_map_string_stringPointer
=== PAUSE TestKeyValueTagsEqual/nil
=== PAUSE TestKeyValueTagsDefaultConfigGetTags/with_Tags_config
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/no_tags
=== RUN   TestKeyValueTagsEqual/empty
=== RUN   TestKeyValueTagsKeyExists/matching_with_nil_value
=== PAUSE TestKeyValueTagsEqual/empty
=== RUN   TestKeyValueTagsKeys/empty_map_string_string
=== PAUSE TestKeyValueTagsKeyExists/matching_with_nil_value
=== RUN   TestKeyValueTagsEqual/source_nil
=== PAUSE TestKeyValueTagsKeys/empty_map_string_string
=== RUN   TestKeyValueTagsKeyTagData/matching_with_additional_boolean_fields
=== RUN   TestKeyValueTagsKeys/empty_slice_interface
=== PAUSE TestKeyValueTagsEqual/source_nil
=== PAUSE TestKeyValueTagsKeyTagData/matching_with_additional_boolean_fields
=== PAUSE TestKeyValueTagsKeys/empty_slice_interface
=== RUN   TestKeyValueTagsEqual/source_empty
=== RUN   TestKeyValueTagsKeys/empty_slice_string
=== PAUSE TestKeyValueTagsEqual/source_empty
=== CONT  TestKeyValueTagsRemoved
=== RUN   TestKeyValueTagsEqual/target_nil
=== RUN   TestKeyValueTagsString/single
=== PAUSE TestKeyValueTagsEqual/target_nil
=== PAUSE TestKeyValueTagsKeys/empty_slice_string
=== RUN   TestKeyValueTagsEqual/target_empty
=== RUN   TestKeyValueTagsIgnorePrefixes/all_prefix
=== RUN   TestKeyValueTagsRemoved/empty
=== PAUSE TestKeyValueTagsIgnorePrefixes/all_prefix
=== PAUSE TestKeyValueTagsHash/empty
=== PAUSE TestKeyValueTagsURLQueryString/empty
=== RUN   TestKeyValueTagsHash/nil_value
=== PAUSE TestKeyValueTagsIgnoreAWS/all
=== RUN   TestKeyValueTagsURLQueryString/nil_value
=== PAUSE TestKeyValueTagsHash/nil_value
=== RUN   TestKeyValueTagsIgnoreAWS/mixed
=== RUN   TestKeyValueTagsHash/not_empty
=== PAUSE TestKeyValueTagsURLQueryString/nil_value
=== RUN   TestKeyValueTagsKeyValues/non-existent
=== PAUSE TestKeyValueTagsHash/not_empty
=== RUN   TestKeyValueTagsURLQueryString/single
=== PAUSE TestKeyValueTagsKeyValues/non-existent
=== PAUSE TestKeyValueTagsURLEncode/empty
=== CONT  TestKeyValueTagsIgnore
=== RUN   TestKeyValueTagsKeyValues/matching_with_string_value
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/non-existent_key
=== PAUSE TestKeyValueTagsKeyValues/matching_with_string_value
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/non-existent_TagData
=== RUN   TestKeyValueTagsKeyValues/matching_with_nil_value
=== RUN   TestKeyValueTagsRemoveDefaultConfig/keys_all_matching
=== RUN   TestKeyValueTagsIgnore/empty
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/keys_all_matching
=== RUN   TestKeyValueTagsRemoveDefaultConfig/keys_some_matching
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/empty_config_and_no_tags
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/keys_some_matching
=== PAUSE TestKeyValueTagsKeyValues/matching_with_nil_value
=== RUN   TestKeyValueTagsContainsAll/exact_match
=== CONT  TestKeyValueTagsMerge
=== PAUSE TestKeyValueTagsIgnore/empty
=== PAUSE TestKeyValueTagsContainsAll/exact_match
=== CONT  TestKeyValueTagsChunks
=== RUN   TestKeyValueTagsIgnore/all
=== PAUSE TestKeyValueTagsIgnore/all
=== RUN   TestKeyValueTagsKeyTagData/matching_with_string_value
=== RUN   TestKeyValueTagsIgnore/mixed
=== PAUSE TestKeyValueTagsString/single
=== PAUSE TestKeyValueTagsKeyTagData/matching_with_string_value
=== PAUSE TestKeyValueTagsIgnore/mixed
=== RUN   TestKeyValueTagsString/multiple
=== RUN   TestKeyValueTagsKeys/non_empty_map_string_interface
=== PAUSE TestKeyValueTagsEqual/target_empty
=== RUN   TestKeyValueTagsIgnorePrefixes/mixed
=== PAUSE TestKeyValueTagsRemoved/empty
=== PAUSE TestKeyValueTagsIgnoreAWS/mixed
=== RUN   TestKeyValueTagsIgnoreConfig/keys_none_matching
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/empty
=== CONT  TestKeyValueTagsUpdated
=== RUN   TestKeyValueTagsURLEncode/nil_value
=== PAUSE TestKeyValueTagsURLQueryString/single
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/non-existent_TagData
=== RUN   TestKeyValueTagsRemoveDefaultConfig/keys_some_overridden
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/no_tags
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/empty_config_and_no_tags
=== RUN   TestKeyValueTagsMerge/empty
=== RUN   TestKeyValueTagsContainsAll/source_contains_all
=== RUN   TestKeyValueTagsChunks/empty
=== RUN   TestKeyValueTagsKeyTagData/matching_with_nil_value
=== PAUSE TestKeyValueTagsURLEncode/nil_value
=== PAUSE TestKeyValueTagsIgnoreConfig/keys_none_matching
=== RUN   TestKeyValueTagsURLQueryString/multiple
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/non-existent_field
=== PAUSE TestKeyValueTagsChunks/empty
=== PAUSE TestKeyValueTagsString/multiple
=== RUN   TestKeyValueTagsEqual/nil_value_matches
=== CONT  TestKeyValueTagsOnly
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/keys_some_overridden
=== RUN   TestKeyValueTagsRemoved/all_new
=== RUN   TestKeyValueTagsIgnoreAWS/none
=== RUN   TestKeyValueTagsIgnoreConfig/keys_and_key_prefixes
=== PAUSE TestKeyValueTagsIgnoreAWS/none
=== PAUSE TestKeyValueTagsIgnorePrefixes/mixed
=== CONT  TestKeyValueTagsMap
=== RUN   TestKeyValueTagsOnly/empty
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/keys_all_matching
=== RUN   TestKeyValueTagsRemoveDefaultConfig/keys_none_matching
=== PAUSE TestKeyValueTagsEqual/nil_value_matches
=== PAUSE TestKeyValueTagsMerge/empty
=== RUN   TestKeyValueTagsIgnore/none
=== PAUSE TestKeyValueTagsRemoved/all_new
=== PAUSE TestKeyValueTagsKeyTagData/matching_with_nil_value
=== PAUSE TestKeyValueTagsIgnore/none
=== PAUSE TestKeyValueTagsRemoveDefaultConfig/keys_none_matching
=== RUN   TestKeyValueTagsRemoved/mixed
=== CONT  TestKeyValueTagsIgnoreSystem/empty
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/keys_all_matching
=== PAUSE TestKeyValueTagsRemoved/mixed
=== PAUSE TestKeyValueTagsContainsAll/source_contains_all
=== CONT  TestKeyValueTagsIgnoreSystem/all
=== RUN   TestKeyValueTagsChunks/chunk_1
=== PAUSE TestKeyValueTagsChunks/chunk_1
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/no_config_and_tags
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/no_config_and_tags
=== RUN   TestKeyValueTagsURLEncode/single
=== CONT  TestKeyValueTagsIgnoreElasticbeanstalk/empty
=== PAUSE TestKeyValueTagsURLEncode/single
=== PAUSE TestKeyValueTagsURLQueryString/multiple
=== RUN   TestKeyValueTagsURLQueryString/multiple_with_encoded
=== RUN   TestKeyValueTagsEqual/exact_match
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/non-existent_field
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/keys_some_matching
=== PAUSE TestKeyValueTagsURLQueryString/multiple_with_encoded
=== CONT  TestKeyValueTagsIgnoreElasticbeanstalk/mixed
=== CONT  TestKeyValueTagsIgnoreElasticbeanstalk/all
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/keys_some_matching
=== PAUSE TestKeyValueTagsIgnoreConfig/keys_and_key_prefixes
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/keys_some_overridden
=== RUN   TestKeyValueTagsRemoved/no_changes
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/keys_and_values_all_matching
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/keys_some_overridden
=== CONT  TestKeyValueTagsIgnoreElasticbeanstalk/none
=== CONT  TestKeyValueTagsDefaultConfigGetTags/empty_config
=== CONT  TestKeyValueTagsDefaultConfigGetTags/nil_config
=== PAUSE TestKeyValueTagsOnly/empty
=== RUN   TestKeyValueTagsUpdated/empty
=== RUN   TestKeyValueTagsMap/empty_map_string_interface
=== PAUSE TestKeyValueTagsKeys/non_empty_map_string_interface
=== CONT  TestKeyValueTagsIgnoreSystem/none
=== CONT  TestKeyValueTagsIgnoreSystem/mixed
=== RUN   TestKeyValueTagsMerge/add_all
=== PAUSE TestKeyValueTagsEqual/exact_match
=== RUN   TestKeyValueTagsURLEncode/multiple
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/matching_value
=== RUN   TestKeyValueTagsChunks/chunk_2
=== RUN   TestKeyValueTagsContainsAll/source_does_not_contain_all
=== PAUSE TestKeyValueTagsMap/empty_map_string_interface
=== PAUSE TestKeyValueTagsUpdated/empty
=== PAUSE TestKeyValueTagsChunks/chunk_2
=== CONT  TestKeyValueTagsKeyExists/matching_with_nil_value
=== RUN   TestKeyValueTagsUpdated/all_new
=== CONT  TestKeyValueTagsKeyExists/non-existent
=== RUN   TestKeyValueTagsChunks/chunk_3
=== RUN   TestKeyValueTagsEqual/source_contains_all
=== PAUSE TestKeyValueTagsUpdated/all_new
=== RUN   TestKeyValueTagsUpdated/mixed
=== CONT  TestKeyValueTagsHash/empty
=== RUN   TestKeyValueTagsDefaultConfigMergeTags/keys_none_matching
=== RUN   TestKeyValueTagsIgnoreConfig/key_prefixes_all_exact
=== CONT  TestKeyValueTagsDefaultConfigGetTags/with_Tags_config
--- PASS: TestKeyValueTagsIgnoreElasticbeanstalk (0.00s)
    --- PASS: TestKeyValueTagsIgnoreElasticbeanstalk/empty (0.00s)
    --- PASS: TestKeyValueTagsIgnoreElasticbeanstalk/mixed (0.00s)
    --- PASS: TestKeyValueTagsIgnoreElasticbeanstalk/all (0.00s)
    --- PASS: TestKeyValueTagsIgnoreElasticbeanstalk/none (0.00s)
=== CONT  TestKeyValueTagsKeyExists/empty
--- PASS: TestKeyValueTagsIgnoreSystem (0.00s)
    --- PASS: TestKeyValueTagsIgnoreSystem/empty (0.00s)
    --- PASS: TestKeyValueTagsIgnoreSystem/all (0.00s)
    --- PASS: TestKeyValueTagsIgnoreSystem/none (0.00s)
    --- PASS: TestKeyValueTagsIgnoreSystem/mixed (0.00s)
=== RUN   TestKeyValueTagsIgnorePrefixes/none
=== RUN   TestKeyValueTagsOnly/all
=== PAUSE TestKeyValueTagsOnly/all
=== RUN   TestKeyValueTagsKeys/non_empty_map_string_string
--- PASS: TestKeyValueTagsDefaultConfigGetTags (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigGetTags/empty_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigGetTags/nil_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigGetTags/with_Tags_config (0.00s)
=== CONT  TestKeyValueTagsKeyExists/matching_with_string_value
=== PAUSE TestKeyValueTagsKeys/non_empty_map_string_string
=== CONT  TestKeyValueTagsKeyValues/matching_with_nil_value
=== PAUSE TestKeyValueTagsContainsAll/source_does_not_contain_all
=== RUN   TestKeyValueTagsKeys/non_empty_map_string_stringPointer
=== CONT  TestKeyValueTagsKeyValues/matching_with_string_value
--- PASS: TestKeyValueTagsKeyExists (0.00s)
    --- PASS: TestKeyValueTagsKeyExists/matching_with_nil_value (0.00s)
    --- PASS: TestKeyValueTagsKeyExists/non-existent (0.00s)
    --- PASS: TestKeyValueTagsKeyExists/empty (0.00s)
    --- PASS: TestKeyValueTagsKeyExists/matching_with_string_value (0.00s)
=== PAUSE TestKeyValueTagsKeys/non_empty_map_string_stringPointer
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/empty
=== RUN   TestKeyValueTagsKeys/non_empty_slice_interface
=== PAUSE TestKeyValueTagsKeys/non_empty_slice_interface
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/keys_and_values_all_matching
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/non-existent_key
=== RUN   TestKeyValueTagsKeys/non_empty_slice_string
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/non-existent_key
=== PAUSE TestKeyValueTagsRemoved/no_changes
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/non-existent_TagData
=== CONT  TestKeyValueTagsString/multiple
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/matching_value
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/non-existent_TagData
=== RUN   TestKeyValueTagsKeyAdditionalBoolValue/matching_nil
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/non-existent_field
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/non-existent_field
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/matching_value
=== PAUSE TestKeyValueTagsURLEncode/multiple
=== PAUSE TestKeyValueTagsMerge/add_all
=== PAUSE TestKeyValueTagsUpdated/mixed
=== PAUSE TestKeyValueTagsChunks/chunk_3
=== PAUSE TestKeyValueTagsEqual/source_contains_all
=== PAUSE TestKeyValueTagsDefaultConfigMergeTags/keys_none_matching
=== PAUSE TestKeyValueTagsIgnoreConfig/key_prefixes_all_exact
=== CONT  TestKeyValueTagsHash/nil_value
=== CONT  TestKeyValueTagsHash/not_empty
=== CONT  TestKeyValueTagsKeyValues/empty
=== RUN   TestKeyValueTagsOnly/mixed
=== PAUSE TestKeyValueTagsIgnorePrefixes/none
=== CONT  TestKeyValueTagsKeyValues/non-existent
=== RUN   TestKeyValueTagsMap/empty_map_string_string
=== CONT  TestKeyValueTagsString/empty
=== RUN   TestKeyValueTagsDefaultConfigTagsEqual/only_keys_matching
=== PAUSE TestKeyValueTagsKeys/non_empty_slice_string
=== PAUSE TestKeyValueTagsKeyAdditionalBoolValue/matching_nil
=== CONT  TestKeyValueTagsString/single
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/matching_value
=== CONT  TestKeyValueTagsString/no_value
=== RUN   TestKeyValueTagsKeyAdditionalStringValue/matching_nil
=== PAUSE TestKeyValueTagsKeyAdditionalStringValue/matching_nil
=== PAUSE TestKeyValueTagsDefaultConfigTagsEqual/only_keys_matching
=== CONT  TestKeyValueTagsKeyTagData/matching_with_nil_value
=== CONT  TestKeyValueTagsIgnoreAWS/all
=== RUN   TestKeyValueTagsChunks/chunk_4
=== CONT  TestKeyValueTagsIgnore/all
=== PAUSE TestKeyValueTagsMap/empty_map_string_string
=== CONT  TestKeyValueTagsRemoveDefaultConfig/keys_some_matching
=== PAUSE TestKeyValueTagsChunks/chunk_4
=== RUN   TestKeyValueTagsMap/empty_map_string_stringPointer
=== RUN   TestKeyValueTagsChunks/chunk_5
=== PAUSE TestKeyValueTagsMap/empty_map_string_stringPointer
=== CONT  TestKeyValueTagsKeyTagData/empty
=== RUN   TestKeyValueTagsMap/non_empty_map_string_interface
=== RUN   TestKeyValueTagsMerge/mixed
=== CONT  TestKeyValueTagsRemoveDefaultConfig/keys_all_matching
=== PAUSE TestKeyValueTagsMerge/mixed
=== RUN   TestKeyValueTagsIgnoreConfig/key_prefixes_all_prefixed
=== PAUSE TestKeyValueTagsMap/non_empty_map_string_interface
=== RUN   TestKeyValueTagsMerge/update_all
=== PAUSE TestKeyValueTagsIgnoreConfig/key_prefixes_all_prefixed
=== CONT  TestKeyValueTagsIgnoreAWS/empty
=== RUN   TestKeyValueTagsIgnoreConfig/key_prefixes_some_prefixed
=== PAUSE TestKeyValueTagsOnly/mixed
=== CONT  TestKeyValueTagsRemoveDefaultConfig/no_tags
=== CONT  TestKeyValueTagsRemoveDefaultConfig/keys_some_overridden
=== RUN   TestKeyValueTagsOnly/none
=== PAUSE TestKeyValueTagsIgnoreConfig/key_prefixes_some_prefixed
=== RUN   TestKeyValueTagsEqual/source_does_not_contain_all
=== CONT  TestKeyValueTagsURLQueryString/empty
=== CONT  TestKeyValueTagsIgnoreAWS/mixed
=== CONT  TestKeyValueTagsURLQueryString/multiple
=== PAUSE TestKeyValueTagsOnly/none
=== CONT  TestKeyValueTagsURLQueryString/multiple_with_encoded
=== CONT  TestKeyValueTagsURLQueryString/nil_value
=== RUN   TestKeyValueTagsUpdated/no_changes
=== CONT  TestKeyValueTagsContainsAll/empty
=== PAUSE TestKeyValueTagsUpdated/no_changes
=== CONT  TestKeyValueTagsContainsAll/target_empty
=== CONT  TestKeyValueTagsIgnoreAWS/none
=== CONT  TestKeyValueTagsContainsAll/source_does_not_contain_all
--- PASS: TestKeyValueTagsKeyValues (0.00s)
    --- PASS: TestKeyValueTagsKeyValues/matching_with_nil_value (0.00s)
    --- PASS: TestKeyValueTagsKeyValues/matching_with_string_value (0.00s)
    --- PASS: TestKeyValueTagsKeyValues/non-existent (0.00s)
    --- PASS: TestKeyValueTagsKeyValues/empty (0.00s)
=== CONT  TestKeyValueTagsContainsAll/source_empty
=== RUN   TestKeyValueTagsURLEncode/multiple_with_encoded
=== CONT  TestKeyValueTagsContainsAll/source_contains_all
=== PAUSE TestKeyValueTagsURLEncode/multiple_with_encoded
=== CONT  TestKeyValueTagsKeyTagData/matching_with_string_value
=== CONT  TestKeyValueTagsRemoved/no_changes
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/empty_config
=== CONT  TestKeyValueTagsRemoved/all_new
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/keys_none_matching
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/keys_some_overridden
=== CONT  TestKeyValueTagsKeyTagData/matching_with_additional_boolean_fields
=== CONT  TestKeyValueTagsIgnore/empty
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/no_tags
=== CONT  TestKeyValueTagsIgnore/mixed
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/no_config
=== CONT  TestKeyValueTagsKeyTagData/non-existent
=== CONT  TestKeyValueTagsKeys/non_empty_map_string_string
=== CONT  TestKeyValueTagsRemoveDefaultConfig/empty_config
=== CONT  TestKeyValueTagsKeys/non_empty_slice_string
=== CONT  TestKeyValueTagsKeys/non_empty_map_string_stringPointer
=== CONT  TestKeyValueTagsIgnorePrefixes/empty
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/non-existent_key
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/non-existent_TagData
=== PAUSE TestKeyValueTagsMerge/update_all
=== CONT  TestKeyValueTagsIgnorePrefixes/none
=== CONT  TestKeyValueTagsIgnorePrefixes/all_prefix
=== RUN   TestKeyValueTagsMap/non_empty_map_string_string
=== CONT  TestKeyValueTagsIgnorePrefixes/all_exact
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/empty_config
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/matching_value
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/matching_nil
=== CONT  TestKeyValueTagsRemoveDefaultConfig/keys_none_matching
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/only_keys_matching
=== PAUSE TestKeyValueTagsMap/non_empty_map_string_string
=== CONT  TestKeyValueTagsRemoveDefaultConfig/no_config
=== CONT  TestKeyValueTagsKeys/non_empty_map_string_interface
=== CONT  TestKeyValueTagsKeys/empty_slice_string
=== CONT  TestKeyValueTagsKeys/empty_slice_interface
=== CONT  TestKeyValueTagsKeys/empty_map_string_string
=== RUN   TestKeyValueTagsIgnoreConfig/key_prefixes_none_prefixed
=== PAUSE TestKeyValueTagsEqual/source_does_not_contain_all
=== CONT  TestKeyValueTagsURLQueryString/single
=== CONT  TestKeyValueTagsContainsAll/exact_match
=== CONT  TestKeyValueTagsContainsAll/nil_value_matches
--- PASS: TestKeyValueTagsHash (0.00s)
    --- PASS: TestKeyValueTagsHash/empty (0.00s)
    --- PASS: TestKeyValueTagsHash/nil_value (0.00s)
    --- PASS: TestKeyValueTagsHash/not_empty (0.00s)
=== CONT  TestKeyValueTagsRemoved/empty
=== CONT  TestKeyValueTagsRemoved/mixed
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/keys_some_matching
=== CONT  TestKeyValueTagsDefaultConfigMergeTags/keys_all_matching
--- PASS: TestKeyValueTagsString (0.00s)
    --- PASS: TestKeyValueTagsString/multiple (0.00s)
    --- PASS: TestKeyValueTagsString/empty (0.00s)
    --- PASS: TestKeyValueTagsString/single (0.00s)
    --- PASS: TestKeyValueTagsString/no_value (0.00s)
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/keys_and_values_all_matching
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/no_config_and_tags
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/empty_tags
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/no_config
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/empty_config_and_no_tags
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/empty
=== CONT  TestKeyValueTagsIgnore/none
=== CONT  TestKeyValueTagsKeys/empty_map_string_interface
=== CONT  TestKeyValueTagsKeys/non_empty_slice_interface
--- PASS: TestKeyValueTagsContainsAll (0.01s)
    --- PASS: TestKeyValueTagsContainsAll/target_empty (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/empty (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/source_does_not_contain_all (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/source_empty (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/source_contains_all (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/exact_match (0.00s)
    --- PASS: TestKeyValueTagsContainsAll/nil_value_matches (0.00s)
=== PAUSE TestKeyValueTagsChunks/chunk_5
=== CONT  TestKeyValueTagsIgnorePrefixes/mixed
=== CONT  TestKeyValueTagsOnly/mixed
--- PASS: TestKeyValueTagsRemoveDefaultConfig (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/keys_all_matching (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/keys_some_matching (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/no_tags (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/keys_some_overridden (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/empty_config (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/keys_none_matching (0.00s)
    --- PASS: TestKeyValueTagsRemoveDefaultConfig/no_config (0.00s)
=== RUN   TestKeyValueTagsMap/non_empty_map_string_stringPointer
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/empty
=== PAUSE TestKeyValueTagsMap/non_empty_map_string_stringPointer
=== RUN   TestKeyValueTagsMap/empty_value
=== CONT  TestKeyValueTagsURLEncode/multiple_with_encoded
=== PAUSE TestKeyValueTagsMap/empty_value
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/matching_nil
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/matching_value
=== RUN   TestKeyValueTagsEqual/target_value_neq
=== PAUSE TestKeyValueTagsIgnoreConfig/key_prefixes_none_prefixed
=== CONT  TestKeyValueTagsKeys/empty_map_string_stringPointer
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/non-existent_TagData
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/non-existent_field
=== CONT  TestKeyValueTagsKeyAdditionalBoolValue/non-existent_key
=== CONT  TestKeyValueTagsDefaultConfigTagsEqual/no_tags
=== CONT  TestKeyValueTagsOnly/empty
=== CONT  TestKeyValueTagsOnly/none
=== CONT  TestKeyValueTagsUpdated/empty
=== CONT  TestKeyValueTagsKeyAdditionalStringValue/non-existent_field
=== CONT  TestKeyValueTagsUpdated/no_changes
=== CONT  TestKeyValueTagsOnly/all
=== CONT  TestKeyValueTagsUpdated/mixed
=== CONT  TestKeyValueTagsUpdated/all_new
=== CONT  TestKeyValueTagsURLEncode/empty
--- PASS: TestKeyValueTagsURLQueryString (0.00s)
    --- PASS: TestKeyValueTagsURLQueryString/empty (0.00s)
    --- PASS: TestKeyValueTagsURLQueryString/multiple (0.00s)
    --- PASS: TestKeyValueTagsURLQueryString/nil_value (0.00s)
    --- PASS: TestKeyValueTagsURLQueryString/multiple_with_encoded (0.00s)
    --- PASS: TestKeyValueTagsURLQueryString/single (0.00s)
=== CONT  TestKeyValueTagsIgnoreConfig/key_prefixes_some_prefixed
--- PASS: TestKeyValueTagsKeyTagData (0.00s)
    --- PASS: TestKeyValueTagsKeyTagData/matching_with_nil_value (0.00s)
    --- PASS: TestKeyValueTagsKeyTagData/empty (0.00s)
    --- PASS: TestKeyValueTagsKeyTagData/matching_with_string_value (0.00s)
    --- PASS: TestKeyValueTagsKeyTagData/matching_with_additional_boolean_fields (0.00s)
    --- PASS: TestKeyValueTagsKeyTagData/non-existent (0.00s)
=== CONT  TestKeyValueTagsIgnoreConfig/key_prefixes_all_exact
--- PASS: TestKeyValueTagsDefaultConfigMergeTags (0.01s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/empty_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/keys_none_matching (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/keys_some_overridden (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/no_tags (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/no_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/keys_some_matching (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigMergeTags/keys_all_matching (0.00s)
=== CONT  TestKeyValueTagsIgnoreConfig/no_tags
=== CONT  TestKeyValueTagsIgnoreConfig/keys_and_key_prefixes
=== PAUSE TestKeyValueTagsEqual/target_value_neq
=== CONT  TestKeyValueTagsIgnoreConfig/no_config
=== CONT  TestKeyValueTagsIgnoreConfig/keys_all_matching
=== CONT  TestKeyValueTagsIgnoreConfig/keys_some_matching
=== CONT  TestKeyValueTagsURLEncode/multiple
=== CONT  TestKeyValueTagsEqual/nil_value_matches
=== CONT  TestKeyValueTagsURLEncode/nil_value
=== CONT  TestKeyValueTagsEqual/source_does_not_contain_all
=== CONT  TestKeyValueTagsEqual/target_empty
=== CONT  TestKeyValueTagsEqual/target_value_neq
=== CONT  TestKeyValueTagsEqual/source_nil
=== CONT  TestKeyValueTagsMerge/empty
=== CONT  TestKeyValueTagsEqual/exact_match
=== CONT  TestKeyValueTagsEqual/empty
=== CONT  TestKeyValueTagsEqual/source_empty
=== CONT  TestKeyValueTagsMerge/mixed
=== CONT  TestKeyValueTagsMerge/update_all
=== CONT  TestKeyValueTagsMerge/add_all
=== CONT  TestKeyValueTagsChunks/empty
=== CONT  TestKeyValueTagsChunks/chunk_2
=== CONT  TestKeyValueTagsChunks/chunk_5
=== CONT  TestKeyValueTagsChunks/chunk_1
=== CONT  TestKeyValueTagsChunks/chunk_4
=== CONT  TestKeyValueTagsChunks/chunk_3
=== CONT  TestKeyValueTagsIgnoreConfig/empty_config
=== CONT  TestKeyValueTagsIgnoreConfig/key_prefixes_none_prefixed
=== CONT  TestKeyValueTagsIgnoreConfig/key_prefixes_all_prefixed
=== RUN   TestKeyValueTagsMap/nil_value
=== PAUSE TestKeyValueTagsMap/nil_value
--- PASS: TestKeyValueTagsRemoved (0.01s)
    --- PASS: TestKeyValueTagsRemoved/no_changes (0.00s)
    --- PASS: TestKeyValueTagsRemoved/all_new (0.00s)
    --- PASS: TestKeyValueTagsRemoved/mixed (0.00s)
    --- PASS: TestKeyValueTagsRemoved/empty (0.00s)
=== CONT  TestKeyValueTagsMap/empty_map_string_string
=== CONT  TestKeyValueTagsMap/empty_map_string_stringPointer
=== CONT  TestKeyValueTagsIgnoreConfig/keys_none_matching
--- PASS: TestKeyValueTagsKeyAdditionalBoolValue (0.01s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/empty (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/matching_value (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/non-existent_key (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/non-existent_TagData (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/matching_nil (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalBoolValue/non-existent_field (0.00s)
=== CONT  TestKeyValueTagsEqual/nil
=== CONT  TestKeyValueTagsEqual/source_contains_all
=== CONT  TestKeyValueTagsURLEncode/single
=== CONT  TestKeyValueTagsEqual/target_nil
=== CONT  TestKeyValueTagsMap/empty_map_string_interface
=== CONT  TestKeyValueTagsMap/nil_value
=== CONT  TestKeyValueTagsMap/empty_value
=== CONT  TestKeyValueTagsMap/non_empty_map_string_stringPointer
=== CONT  TestKeyValueTagsMap/non_empty_map_string_string
=== CONT  TestKeyValueTagsMap/non_empty_map_string_interface
--- PASS: TestKeyValueTagsIgnoreAWS (0.00s)
    --- PASS: TestKeyValueTagsIgnoreAWS/all (0.00s)
    --- PASS: TestKeyValueTagsIgnoreAWS/empty (0.00s)
    --- PASS: TestKeyValueTagsIgnoreAWS/mixed (0.00s)
    --- PASS: TestKeyValueTagsIgnoreAWS/none (0.00s)
--- PASS: TestKeyValueTagsIgnorePrefixes (0.01s)
    --- PASS: TestKeyValueTagsIgnorePrefixes/empty (0.00s)
    --- PASS: TestKeyValueTagsIgnorePrefixes/all_prefix (0.00s)
    --- PASS: TestKeyValueTagsIgnorePrefixes/none (0.00s)
    --- PASS: TestKeyValueTagsIgnorePrefixes/all_exact (0.00s)
    --- PASS: TestKeyValueTagsIgnorePrefixes/mixed (0.00s)
--- PASS: TestKeyValueTagsIgnore (0.00s)
    --- PASS: TestKeyValueTagsIgnore/all (0.00s)
    --- PASS: TestKeyValueTagsIgnore/empty (0.00s)
    --- PASS: TestKeyValueTagsIgnore/mixed (0.00s)
    --- PASS: TestKeyValueTagsIgnore/none (0.00s)
--- PASS: TestKeyValueTagsDefaultConfigTagsEqual (0.01s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/empty_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/only_keys_matching (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/no_config_and_tags (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/keys_and_values_all_matching (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/no_config (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/empty_tags (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/empty_config_and_no_tags (0.00s)
    --- PASS: TestKeyValueTagsDefaultConfigTagsEqual/no_tags (0.00s)
--- PASS: TestKeyValueTagsUpdated (0.01s)
    --- PASS: TestKeyValueTagsUpdated/all_new (0.00s)
    --- PASS: TestKeyValueTagsUpdated/mixed (0.00s)
    --- PASS: TestKeyValueTagsUpdated/empty (0.00s)
    --- PASS: TestKeyValueTagsUpdated/no_changes (0.00s)
--- PASS: TestKeyValueTagsChunks (0.01s)
    --- PASS: TestKeyValueTagsChunks/chunk_2 (0.00s)
    --- PASS: TestKeyValueTagsChunks/empty (0.00s)
    --- PASS: TestKeyValueTagsChunks/chunk_5 (0.00s)
    --- PASS: TestKeyValueTagsChunks/chunk_4 (0.00s)
    --- PASS: TestKeyValueTagsChunks/chunk_1 (0.00s)
    --- PASS: TestKeyValueTagsChunks/chunk_3 (0.00s)
--- PASS: TestKeyValueTagsMerge (0.01s)
    --- PASS: TestKeyValueTagsMerge/empty (0.00s)
    --- PASS: TestKeyValueTagsMerge/mixed (0.00s)
    --- PASS: TestKeyValueTagsMerge/update_all (0.00s)
    --- PASS: TestKeyValueTagsMerge/add_all (0.00s)
--- PASS: TestKeyValueTagsKeys (0.01s)
    --- PASS: TestKeyValueTagsKeys/non_empty_map_string_string (0.00s)
    --- PASS: TestKeyValueTagsKeys/non_empty_slice_string (0.00s)
    --- PASS: TestKeyValueTagsKeys/non_empty_map_string_stringPointer (0.00s)
    --- PASS: TestKeyValueTagsKeys/non_empty_map_string_interface (0.00s)
    --- PASS: TestKeyValueTagsKeys/empty_slice_string (0.00s)
    --- PASS: TestKeyValueTagsKeys/empty_slice_interface (0.00s)
    --- PASS: TestKeyValueTagsKeys/empty_map_string_string (0.00s)
    --- PASS: TestKeyValueTagsKeys/non_empty_slice_interface (0.00s)
    --- PASS: TestKeyValueTagsKeys/empty_map_string_interface (0.00s)
    --- PASS: TestKeyValueTagsKeys/empty_map_string_stringPointer (0.00s)
--- PASS: TestKeyValueTagsKeyAdditionalStringValue (0.01s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/non-existent_key (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/non-existent_TagData (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/matching_value (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/matching_nil (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/empty (0.00s)
    --- PASS: TestKeyValueTagsKeyAdditionalStringValue/non-existent_field (0.00s)
--- PASS: TestKeyValueTagsEqual (0.01s)
    --- PASS: TestKeyValueTagsEqual/nil_value_matches (0.00s)
    --- PASS: TestKeyValueTagsEqual/source_does_not_contain_all (0.00s)
    --- PASS: TestKeyValueTagsEqual/target_empty (0.00s)
    --- PASS: TestKeyValueTagsEqual/source_nil (0.00s)
    --- PASS: TestKeyValueTagsEqual/target_value_neq (0.00s)
    --- PASS: TestKeyValueTagsEqual/exact_match (0.00s)
    --- PASS: TestKeyValueTagsEqual/empty (0.00s)
    --- PASS: TestKeyValueTagsEqual/source_empty (0.00s)
    --- PASS: TestKeyValueTagsEqual/target_nil (0.00s)
    --- PASS: TestKeyValueTagsEqual/source_contains_all (0.00s)
    --- PASS: TestKeyValueTagsEqual/nil (0.00s)
--- PASS: TestKeyValueTagsOnly (0.01s)
    --- PASS: TestKeyValueTagsOnly/mixed (0.00s)
    --- PASS: TestKeyValueTagsOnly/none (0.00s)
    --- PASS: TestKeyValueTagsOnly/empty (0.00s)
    --- PASS: TestKeyValueTagsOnly/all (0.00s)
--- PASS: TestKeyValueTagsMap (0.01s)
    --- PASS: TestKeyValueTagsMap/empty_map_string_string (0.00s)
    --- PASS: TestKeyValueTagsMap/empty_map_string_stringPointer (0.00s)
    --- PASS: TestKeyValueTagsMap/empty_map_string_interface (0.00s)
    --- PASS: TestKeyValueTagsMap/nil_value (0.00s)
    --- PASS: TestKeyValueTagsMap/empty_value (0.00s)
    --- PASS: TestKeyValueTagsMap/non_empty_map_string_stringPointer (0.00s)
    --- PASS: TestKeyValueTagsMap/non_empty_map_string_string (0.00s)
    --- PASS: TestKeyValueTagsMap/non_empty_map_string_interface (0.00s)
--- PASS: TestKeyValueTagsIgnoreConfig (0.01s)
    --- PASS: TestKeyValueTagsIgnoreConfig/key_prefixes_some_prefixed (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/key_prefixes_all_exact (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/no_tags (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/keys_and_key_prefixes (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/no_config (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/keys_all_matching (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/keys_some_matching (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/empty_config (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/key_prefixes_none_prefixed (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/key_prefixes_all_prefixed (0.00s)
    --- PASS: TestKeyValueTagsIgnoreConfig/keys_none_matching (0.00s)
--- PASS: TestKeyValueTagsURLEncode (0.01s)
    --- PASS: TestKeyValueTagsURLEncode/multiple_with_encoded (0.00s)
    --- PASS: TestKeyValueTagsURLEncode/empty (0.00s)
    --- PASS: TestKeyValueTagsURLEncode/nil_value (0.00s)
    --- PASS: TestKeyValueTagsURLEncode/multiple (0.00s)
    --- PASS: TestKeyValueTagsURLEncode/single (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/tags       0.070s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lightsail Issues and PRs that pertain to the lightsail service. tags Pertains to resource tagging. generators Relates to code generators. labels May 19, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 19, 2024
@acwwat acwwat force-pushed the b-aws_lightsail_instance-fix_empty_tag_crash branch from dcb82b0 to 1697542 Compare May 19, 2024 00:53
@acwwat acwwat marked this pull request as draft May 19, 2024 01:34
@acwwat acwwat force-pushed the b-aws_lightsail_instance-fix_empty_tag_crash branch from 1697542 to b6ca210 Compare May 19, 2024 04:36
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels May 19, 2024
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 20, 2024
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 22, 2024
@acwwat acwwat changed the title [WIP] fix: Fix crash during read due to key-only tags in aws_lightsail_instance fix: Fix crash during read due to key-only tags in aws_lightsail_instance May 22, 2024
@acwwat acwwat marked this pull request as ready for review May 22, 2024 03:22
@acwwat acwwat mentioned this pull request May 23, 2024
Closed
@johnsonaj johnsonaj self-assigned this May 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 24, 2024
johnsonaj
johnsonaj approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE=us-east-1a make testacc TESTARGS='-run=TestAccLightsailInstance_' PKG=lightsail

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailInstance_ -timeout 360m
--- PASS: TestAccLightsailInstance_availabilityZone (3.02s)
--- PASS: TestAccLightsailInstance_disappears (47.23s)
--- PASS: TestAccLightsailInstance_basic (47.42s)
--- PASS: TestAccLightsailInstance_tags (60.22s)
--- PASS: TestAccLightsailInstance_keyOnlyTags (61.11s)
--- PASS: TestAccLightsailInstance_IPAddressType (66.20s)
--- PASS: TestAccLightsailInstance_name (133.61s)
--- PASS: TestAccLightsailInstance_addOn (239.02s)
PASS
ok  	[github.com/hashicorp/terraform-provider-aws/internal/service/lightsail](http://github.com/hashicorp/terraform-provider-aws/internal/service/lightsail)	244.274s

@johnsonaj
Copy link
Contributor

@acwwat thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 44b5a42 into hashicorp:main May 24, 2024
37 checks passed
@github-actions github-actions bot added this to the v5.52.0 milestone May 24, 2024
@acwwat acwwat deleted the b-aws_lightsail_instance-fix_empty_tag_crash branch May 25, 2024 02:13
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 30, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

@johnsonaj johnsonaj

Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/lightsail Issues and PRs that pertain to the lightsail service. size/L Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.52.0
3 participants
@acwwat @johnsonaj @justinretzolk