Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic switches for tplink #117758

Open
wants to merge 40 commits into
base: tplink_rewrite
Choose a base branch
from
Open

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented May 20, 2024

This PR is (the first) part of the tplink rewrite series, to be merged into tplink_rewrite branch (see #111151).

Proposed change

  • Create a foundation to use upstream-provided information for creating entities, allowing to expose support for more devices and features while moving some maintenance burden from homeassistant to the upstream library.
  • Convert switch platform to use the new facilities.
  • Expose sub-devices as their own devices that define via_device.

TBD:

  • TODOs in the code
  • Consolidate unique id handling
  • Tests
  • Documentation update (if it's not better done prior merging the dev branch back to master?)

The screenshot below shows two new entities, and one that was previously hardcoded:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @TheGardenMonkey, @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/tplink/switch.py Outdated Show resolved Hide resolved
homeassistant/components/tplink/entity.py Show resolved Hide resolved
This is necessary as CoordinatedTPLinkEntity checks for parent to decide whether to use identifiers or connections.
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant
Copy link

home-assistant bot commented Jun 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 7, 2024 13:52
rytilahti and others added 5 commits June 7, 2024 18:41
* Inline entity filter
* Allow entity classes to pass legacy unique_id handling as parameter
Adds primary entities to the parent device for devices such as power strips and wall switches.
@rytilahti rytilahti marked this pull request as ready for review June 11, 2024 16:16
@home-assistant home-assistant bot requested a review from sdb9696 June 11, 2024 16:16
Copy link
Contributor

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants