fix: prevent signIn if session present

* test: no sign in while signed in

* test: prevent signIn if session present

* test: remove redundant test

* test: more descriptive test name

* test: typo

* test: fix typo

lib/sign-in.js

@@ -24,6 +24,11 @@ function signIn (state, options) {
   })
 
   .then(function (cache) {
+    // If a different user is signed in than the one trying to signIn, throw an error
+    if (cache.session && cache.username !== options.username) {
+      return Promise.reject(new Error('You must sign out before signing in'))
+    }
+
     return state.hook('signin', options, function (options) {
       return internals.request({
         url: state.url + '/session',

test/integration/sign-in-test.js

@@ -33,7 +33,7 @@ test('sign in', function (t) {
   account.signIn(options)
 
   .then(function (signInResult) {
-    t.pass('signes in')
+    t.pass('signs in')
     t.is(signInResult.username, 'chicken@docs.com')
 
     var storeAccount = store.getObject('account')
@@ -62,7 +62,7 @@ test('sign in', function (t) {
   })
 
   .then(function (signOutResult) {
-    t.pass('signes out')
+    t.pass('signs out')
 
     t.is(signOutResult.username, 'chicken@docs.com')
 
@@ -85,3 +85,34 @@ test('sign in', function (t) {
 
   .catch(t.error)
 })
+
+test('prevent sign-in when already signed in', function (t) {
+  store.clear()
+  t.plan(1)
+
+  var account = new Account({
+    url: baseURL,
+    id: 'abc4567'
+  })
+
+  nock(baseURL)
+    .put('/session')
+    .reply(201, signInResponse)
+
+  account.signIn(options)
+
+  .then(function (signInResult) {
+    return account.signIn({
+      username: 'fox@docs.com',
+      password: 'secret'
+    })
+  })
+
+  .then(function () {
+    t.fail('Sign in must fail when already signed in')
+  })
+
+  .catch(function (error) {
+    t.is(error.message, 'You must sign out before signing in')
+  })
+})