client: add default user agent #140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
force-pushed
the
default-user-agent
branch
from
b30a2d5
to
6b2ce9d
Compare
Fishrock123
force-pushed
the
default-user-agent
branch
from
6b2ce9d
to
0c2fa7b
Compare
Fishrock123
commented
Sep 14, 2020
|
|
||
| mod decode; | ||
| mod encode; | ||
|
|
||
| pub use decode::decode; | ||
| pub use encode::Encoder; | ||
|
|
||
| lazy_static! { | ||
| static ref DEFAULT_USER_AGENT: String = format!("http-rs-h1/{}", env!("CARGO_PKG_VERSION")); |
There was a problem hiding this comment.
Unsure what to call it, async-h1 seems wrong when used by e.g. surf, but also maybe surf should override it anyways. Unsure.
There was a problem hiding this comment.
+1 for surf overriding or appending. why not async-h1, though, since that's the name of the crate? Then it could be something like surf/2.0.0 (async-h1/6.0.0)
|
Note: the tests for this are brittle. The order of added header is non-deterministic (HashMap iterator). |
|
Seems reasonable to sort headers by either addition order or alphabetically |
|
The problem is we are comparing to raw output files and unless headers are always going to be sorted there isn't a way to do that just for test output without re-writing the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in discord, I think.