Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install issues #191

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented May 17, 2024

What this does

  • Downgrade torchvision version constraint
  • Added suggestion to install cmake and build-essential to readme install instructions to help with issues like Installation fails (egl_probe) #105

How it was tested

See this thread on discord

@aliberts aliberts added the ✨ Enhancement New feature or request label May 21, 2024
@aliberts aliberts marked this pull request as ready for review May 22, 2024 08:38
@aliberts aliberts added the ➡️ Dependencies Adding, removing or updating dependencies label May 22, 2024
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion!

README.md Outdated
Comment on lines 80 to 82
> **NOTE:** Depending on your platform, If you encounter any build errors during this step
you may need to install `cmake` and `build-essentials` for building some of our dependencies.

Copy link
Collaborator

@Cadene Cadene May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> **NOTE:** Depending on your platform, If you encounter any build errors during this step
you may need to install `cmake` and `build-essentials` for building some of our dependencies.
> **NOTE:** Depending on your platform, If you encounter any build errors during this step
you may need to install `cmake` and `build-essentials` for building some of our dependencies. On linux:

sudo apt install cmake build-essentials

@aliberts aliberts linked an issue May 23, 2024 that may be closed by this pull request
2 tasks
@aliberts aliberts merged commit 35c1ce7 into main May 23, 2024
5 checks passed
@aliberts aliberts deleted the user/aliberts/2024_05_17_downgrade_torchvision branch May 23, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➡️ Dependencies Adding, removing or updating dependencies ✨ Enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Installation fails (egl_probe)
2 participants