Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Added support for downloading/syncing images from a specified album #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

csimonsson
Copy link

This is my very first pull requests, sorry if I made some mistakes, but I needed to sync a local folder with a specific album so I created this new command for the CLI.

@csimonsson
Copy link
Author

Any suggestions for improvements would be of great value!

@bo0tzz
Copy link
Member

bo0tzz commented Jan 27, 2023

Good stuff! I'll leave the main review to @alextran1502, but there are a few things I would like to see:

  • Can you have the album input be by UUID instead of name? That's a bit more robust, and means you don't need to loop over all the albums to find it. You should be able to get the UUID from the album view URL on the web client
  • I would prefer if this command just downloads the full album, without deleting anything. I understand that your usecase is sync, but in a more general scope I think files being deleted is probably undesirable.

Thanks for the PR!

@csimonsson
Copy link
Author

csimonsson commented Jan 27, 2023

Thanks for the feedback! I'll change to AlbumId!

Regarding the deletions; this is disabled by default and the --delete option is used to enable this (same behavior as in upload command).

By doing so there's both a "download only" and "full sync" functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants