Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkout, clone, push): Add 'onPrePush' and 'onPostCheckout' #1797

Merged
merged 1 commit into from
May 28, 2024

Conversation

CoalZombik
Copy link
Contributor

I'm adding a parameter to an existing command X:

  • add parameter to the function in src/api/X.js (and src/commands/X.js if necessary)
  • document the parameter in the JSDoc comment above the function
  • add a test case in __tests__/test-X.js if possible
  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "feat(X): Added 'bar' parameter"
  • add page to the Docs Sidebar website/sidebars.json

Closes #1186

I added new documentation website/sidebars.json, but I don't know how to handle versioned variants of documentation.

Copy link
Contributor

@jcubic jcubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

docs/onPostCheckout.md Show resolved Hide resolved
docs/onPrePush.md Outdated Show resolved Hide resolved
src/commands/push.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jcubic jcubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

@jcubic
Copy link
Contributor

jcubic commented Apr 2, 2024

Sorry for late reply. Did you change something? I didn't get any notification from GitHub. And you didn't reply to my comments.

@CoalZombik
Copy link
Contributor Author

Yes, I applied changes that you suggested.

Sorry, it probably my fault, I expected that re-requesting a review will send you a notification.

@jcubic jcubic merged commit d361301 into isomorphic-git:main May 28, 2024
4 checks passed
Copy link
Contributor

@jcubic jcubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for late response, I totally forget about this Review. I've found my old notes where I did add a link to the PR.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Git Hooks
2 participants