-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable DecompressionStream detection #1799
base: main
Are you sure you want to change the base?
fix: enable DecompressionStream detection #1799
Conversation
Can you explain what this fixes? It's not clear what is the purpose if this change. Can you write a unit test that fails before the fix and works after the fix? |
Hi. Sorry for taking so long to reply. Because it's set to false in code, the detection never runs and isogit treats DecompressionStream as non-existing (and defaults to pako) at all times. If you look at a neighbouring file deflate.js, you'll see it has a line At some point I'll provide a unit test, but I can't say when exactly yet, sorry. |
269bd0d
to
7076e68
Compare
I have added the unit tests, unfortunately they can't follow the regular style due to usage of local variables. If possible, please assist :) |
There are two issues:
|
The test got fixed, Please rebase and close the stream as on CompressionStream. |
7076e68
to
932eaa3
Compare
932eaa3
to
4ff776c
Compare
Made the necessary changes but it appears that the tests are still failing. I'm not sure the reason is my changes still, the failures seem unrelated. |
It may be related to changes in Zlib library now that decompressionStream is actually used it produces differnet output. I'm not sure how since decompression should unpack old and new data in same way. |
I'm fixing a bug or typo
npm run add-contributor
and follow the prompts to add yourself to the README