Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined ContentLenght and support BinaryStreamOnly in Windows #1198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix undefined ContentLenght and support BinaryStreamOnly in Windows #1198

wants to merge 2 commits into from

Conversation

k1mmm
Copy link
Contributor

@k1mmm k1mmm commented Aug 12, 2023 •
edited

I've seen there's on going work to rework the windows module, but untill then I've fixed two things to get the current Windows module working

  1. Add a ContentLength check to avoid undefined error
  2. Allow raw binary upload (S3 signed urls wants raw binary data, not multipart/form-data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@k1mmm