Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: hidden scrollbar by default #3085

Merged
merged 1 commit into from
May 24, 2024
Merged

style: hidden scrollbar by default #3085

merged 1 commit into from
May 24, 2024

Conversation

eiinu
Copy link
Member

@eiinu eiinu commented May 17, 2024

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • feat: 新特性提交
  • fix: bug 修复
  • docs: 文档改进
  • style: 组件样式/交互改进
  • type: 类型定义更新
  • perf: 性能、包体积优化
  • refactor: 代码重构、代码风格优化
  • test: 测试用例
  • chore(deps): 依赖升级
  • chore(demo): 演示代码改进
  • chore(locale): 国际化改进
  • chore: 其他改动(是关于什么的改动?)

这个 PR 涉及以下平台:

  • NutUI H5 @nutui/nutui
  • NutUI Taro @nutui/nutui-taro

这个 PR 是否已自测:

Summary by CodeRabbit

  • 样式
    • 为电梯组件、列表组件和菜单项组件添加了隐藏webkit滚动条的样式。

Copy link

coderabbitai bot commented May 17, 2024

Walkthrough

最近的更改主要集中在隐藏webkit滚动条的样式上。这些更改分别应用于src/packages/__VUE/elevatorsrc/packages/__VUE/listsrc/packages/__VUE/menuitem目录中的index.scss文件。通过设置滚动条的显示为none和宽度为0,这些文件实现了在webkit浏览器中隐藏滚动条的效果。

Changes

文件路径 更改摘要
src/packages/__VUE/elevator/index.scss index.scss文件中,增加了隐藏webkit滚动条的样式,通过在&::-webkit-scrollbar选择器中设置其显示为none和宽度为0。
src/packages/__VUE/list/index.scss index.scss文件中,增加了隐藏webkit滚动条的样式,通过在&::-webkit-scrollbar选择器中设置其显示为none和宽度为0。
src/packages/__VUE/menuitem/index.scss index.scss文件中,增加了隐藏webkit滚动条的样式,通过在&::-webkit-scrollbar选择器中设置其显示为none和宽度为0。

🐇
滚动条消失不见,
页面清爽又自然。
CSS魔法一挥手,
用户体验更美好。
小兔子轻轻跳跃,
代码世界无限妙。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.97%. Comparing base (2a00413) to head (d488671).

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #3085      +/-   ##
==========================================
- Coverage   84.02%   83.97%   -0.05%     
==========================================
  Files         226      226              
  Lines       22939    22939              
  Branches     2481     2479       -2     
==========================================
- Hits        19274    19264      -10     
- Misses       3647     3657      +10     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2a00413 and d488671.
Files selected for processing (3)
  • src/packages/__VUE/elevator/index.scss (1 hunks)
  • src/packages/__VUE/list/index.scss (1 hunks)
  • src/packages/__VUE/menuitem/index.scss (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/packages/__VUE/elevator/index.scss
  • src/packages/__VUE/list/index.scss
Additional comments not posted (1)
src/packages/__VUE/menuitem/index.scss (1)

32-35: 隐藏滚动条的更改看起来很好,符合PR的目标。

@eiinu eiinu merged commit 095ba8e into jdf2e:v4 May 24, 2024
5 of 6 checks passed
@eiinu eiinu deleted the feat-style branch May 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant