Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EpicEditor with SimpleMDE #667

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fenichelar
Copy link

SimpleMDE Markdown Editor has a toolbar that is much more user friendly. This also resolves the issue caused by EpicEditor not loading if the data was undefined.

@xmiao
Copy link

xmiao commented May 18, 2017

When moving a block up or down with the arrow button, the text in the editor will be gone.

@xmiao
Copy link

xmiao commented May 19, 2017

Adding one more else branch should be sufficient.

    // If using SCEditor, update the WYSIWYG
    if(this.sceditor_instance) {
      this.sceditor_instance.val(sanitized);
    }
    else if(this.SimpleMDE) {
        this.SimpleMDE.value(sanitized);
    }
    else if(this.ace_editor) {
      this.ace_editor.setValue(sanitized);
    }

@fenichelar
Copy link
Author

@xmiao Fixed as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants