Issue 488 fix disabled fields get enabled when using properties dropdown #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed #488 |
… update flag always_disabled for any editor
theyiwenliu
force-pushed
the
issue-488_Fix_disabled_fields_get_enabled_when_using_properties_dropdown
branch
from
16ec92f
to
72bfa10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Check if it is always disabled before enabling any editor
Otherwise editors are enabled when any properties dropdown is used.
Commit 2: If function disable is called with param always_disabled set to true, update flag always_disabled for any editor
We need a way to tell if the disable() is called to "always disable" the editor, or just temporarily (e.g. when properties dropdown is open, it temporarily disables enabled-fields and enables them when it is closed)
It could be done in different ways, the other way I can think of is to have public "disable" and private "_disable function", and only in public one we set "always_disabled" flag to true, and then call private _disable.
Internal disable() calls should be replaced with _disable(), and users can use editor.disable() to "always disable" the editor.