fix for sending 0 and false with remove_empty_properties=true #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dexif, I am going to make some changes based off your develop branch and make a PR to your repo so we can also integrate removing empty objects with these changes... my changes involves a property for "type": "object" properties which specifies whether or not you should remove when it is only default items... you will understand more in about an hour when I make the PR :) |
|
Sorry about the delay on this, this piece of it was a lot simpler than I thought, one of my coworkers found the solution :) #736 |
btsimonh
pushed a commit
to btsimonh/json-editor
that referenced
this pull request
May 26, 2021
Fix parameter order and Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.