-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESM/ES6 #1
Open
brettz9
wants to merge
16
commits into
johnsusi:master
Choose a base branch
from
brettz9:refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ESM/ES6 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build: Switch from Webpack to Rollup - Linting: Add ESLint and apply latest ash-nazg fixers - Linting: Add recommended package.json fields - Maintenance: Add editorconfig, gitignore
- npm: Update devDeps.
- Build: Add ESM export - Refactoring: Use cjs extension in binary file - Linting: Apply latest ash-nazg; switch to babel/eslint-parser - npm: Update devDeps. (including changed peerDeps) - npm: Update `main` and add `exports` field
I also think it'd be cool to have a library pulling together different kinds of JSON iterators, such as for asynchronously received JSON (or possibly JSON reference-based JSON iteration). If you're open to having it here, https://github.com/ibmruntimes/yieldable-json might be adapted to export the iterator it uses internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is your cup of tea or if you're still reviewing PRs, but wanted to make these changes
exports
(and change dist file path)xo
)Thanks!