Fix: Expect return true immediately if If-None-Match matches the ETag header (#35) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbigDreamer
changed the title
UlisesGascon
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Thanks for making this work @bigbigDreamer!
AFAIK, seems like this is a major change in terms of semver. I will love to have some additional reviews before we merge it (I am not an expert on fresh) 👍
|
I don't have the requisite permission to approve, but 👍 ✅ |
there is no perfect answer, but you could argue that a breaking change caused by spec-compliance where you don't do a major version bump does not violate semver. unrelated but similar issue I ran into last week: |
rxmarbles
reviewed
Apr 29, 2024
ctcpip
reviewed
Apr 29, 2024
import-brain
approved these changes
Apr 30, 2024
marco2216
reviewed
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Expect return true immediately if If-None-Match matches the ETag header.
Context
Closes #35