-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Expect return true immediately if If-None-Match matches the ETag header (#35) #38
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this work @bigbigDreamer!
AFAIK, seems like this is a major change in terms of semver. I will love to have some additional reviews before we merge it (I am not an expert on fresh
) 👍
I don't have the requisite permission to approve, but 👍 ✅ |
there is no perfect answer, but you could argue that a breaking change caused by spec-compliance where you don't do a major version bump does not violate semver. unrelated but similar issue I ran into last week: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also don't have perms to approve but a ➕1 from me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the requisite permission to approve, but 👍 ✅
(previous comment doesn't show up in reviews)
Main Changes
Expect return true immediately if If-None-Match matches the ETag header.
Context
Closes #35