Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Merge develop/pr2 branch #384

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

[WIP] Merge develop/pr2 branch #384

wants to merge 22 commits into from

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Sep 30, 2022 •
edited

Moved from #281
knorth55/jsk_3rdparty@pr1040 branch is moved to jsk-ros-pkg/jsk_3rdparty@develop/pr2 branch.

this branch is pr1012's and pr1040's internal branch.
this branch is also used in PR2 + noetic.

this PR includes these PRs.

cc. @Kanazawanaoaki @HiroIshida @nakane11 @708yamaguchi @nakane11

@knorth55 knorth55 added the pr2 label Sep 30, 2022
This was referenced Sep 30, 2022
Closed
Closed
iory and others added 20 commits March 25, 2023 23:47
@iory @knorth55
[respeaker_ros] Publish audio_info
6072701
@iory @knorth55
[respeaker_ros] Enable speech to text for multi channel.
3f08b74
@iory @knorth55
[respeaker_ros] Add audio_info arg in sample
04f6e1a
@iory @knorth55
[respeaker_ros] Add publish_multichannel option for publishing multi …
5bbed14 
…channel audio
@iory @knorth55
[respeaker_ros] Restore audio input to use argment's audio
3340177
@iory @knorth55
[respeaker_ros] Add publish_multichannel option to fix launch file er…
d662b2c 
…ror.
@iory @knorth55
[respeaker_ros] Add roslaunch_add_file_check to test launch file format
6efa2fe
@iory @knorth55
[respeaker_ros] Set audio_info topic name and check length of it.
b85bea5
@iory @knorth55
[respeaker_ros] Add comment for why we add publish_multichannel option.
8bad183
@iory @knorth55
[respeaker_ros] Remove publish_multichannel option and publish raw mu…
bb8d365 
…ltichannel audio as default.
@iory @knorth55
[respeaker_ros] Publish spech_audio_raw
6ed3f11
@iory @knorth55
[respeaker_ros] Add comment to know more defails
d56eed7
@iory @knorth55
[respeaker_ros] Publish speech audio raw
129a581
@iory @knorth55
[respeaker_ros] Add parameters for respaker ros
cd490fb
@iory @knorth55
[respeaker_ros] Fixed publishing audio topic's namespace
d6b1476
@iory @knorth55
[respeaker_ros] Add parameters for speech_to_text
9bb766f
@iory @knorth55
[respeaker_ros] Avoid AudioInfo import for backward compatibility
5b6a376
@iory @knorth55
[respeaker_ros] Fixed bytes calculation 'self.n_channe - 2' -> '(self…
6ac8a40 
….n_channel - 2)'
@knorth55
use sub and not delete
defbba8
@knorth55
fix typo in dialogflow_client.py
1e494d8
@knorth55 knorth55 mentioned this pull request Mar 25, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dialogflow_task_executive pr2 respeaker_ros rostwitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knorth55 @k-okada @iory