-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_recognition_utils] add OpenCV to catkin_depends #2823
base: master
Are you sure you want to change the base?
Conversation
I don't understand fully, but maybe you should just add |
humm,
so, we already have Before applying this patch, How do you think? Too many changes? |
Thank you for your info. At first, I thought that tThishis method was not very clean, but I agreed that it was better to use it because different versions of OpenCV handle it differently in CMake, and cv_bridge did it well.
Yes, it is because
Yes, so I'll handle this.
This is the refactor process so I'll create another PR |
dac0ead
to
64c8795
Compare
@k-okada Kindly ping. I think this PR could be merged |
The current CMake implementation of
jsk_recognition_utils
does not propagate the need for OpenCV downstream, so I fixed it.How to check
Create the package like
package.xml
CMakeLists.txt
include/test_utils/test_utils.h
src/test_utils.cpp
Then compare the
cmake
outputs before this PR and after this PRbefore
and fails to compile with
after
and successfully finds OpenCV