Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .DS_Store to .gitignore #40

Merged
merged 3 commits into from
May 28, 2024

Conversation

DarhkVoyd
Copy link
Member

What kind of change does this PR introduce?
This PR aims to update .gitignore to avoid adding unnecessary MacOS Finder configuration .DS_Store to the repository.

Does this PR introduce a breaking change?
No

@Relequestual
Copy link
Member

If we're going to ignore OS specific things (which we should), it may be best to add a larger list to the .gitignore file rather than just one part.
See https://www.toptal.com/developers/gitignore/api/macos,windows

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file also includes files to be removed from various linux destros ?

@DarhkVoyd
Copy link
Member Author

Does this file also includes files to be removed from various linux destros ?

I am not sure what files are to be excluded for linux.

Copy link
Contributor

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@benjagm
Copy link
Contributor

benjagm commented May 16, 2024

Can you please resolve the conflicts?

@Relequestual Relequestual merged commit 9adce34 into json-schema-org:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants