Add option to show electron window #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
approved these changes
Dec 13, 2019
|
Indeed, especially because Firefox already shows the window and I’d prefer the opposite. Perhaps the opposite of a |
|
I wouldn't mess with the term "headless", that gets confusing. Well if Firefox always shows we can consider "show: true" support to be done already :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing in browser, I find it helpful at times to be able to view the window. This didn't appear possible when using electron as the browser. electron-stream already provides a
showoption, so I simply exposed the option via the bin script and updated the README.md.I assume this qualifies as a "trivial" update, so I am forgoing the process outlined in the contributing guidelines.