Merge pull request #4814 from minrk/activity-warning

quieter logging in activity-reporting when hub is temporarily unavailable
jupyterhub · May 13, 2024 · 06c8d22 · 06c8d22
2 parents 95d479a + ea73931
commit 06c8d22
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/jupyterhub/singleuser/extension.py b/jupyterhub/singleuser/extension.py
@@ -412,9 +412,12 @@ async def notify_activity(self):
             return
 
         last_activity_timestamp = isoformat(last_activity)
+        failure_count = 0
 
         async def notify():
+            nonlocal failure_count
             self.log.debug("Notifying Hub of activity %s", last_activity_timestamp)
+
             req = HTTPRequest(
                 url=self.hub_activity_url,
                 method='POST',
@@ -433,8 +436,12 @@ async def notify():
             )
             try:
                 await client.fetch(req)
-            except Exception:
-                self.log.exception("Error notifying Hub of activity")
+            except Exception as e:
+                failure_count += 1
+                # log traceback at debug-level
+                self.log.debug("Error notifying Hub of activity", exc_info=True)
+                # only one-line error visible by default
+                self.log.error("Error notifying Hub of activity: %s", e)
                 return False
             else:
                 return True
@@ -446,6 +453,8 @@ async def notify():
             max_wait=15,
             timeout=60,
         )
+        if failure_count:
+            self.log.info("Sent hub activity after %s retries", failure_count)
         self._last_activity_sent = last_activity
 
     async def keep_activity_updated(self):