-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix opening active notebook from kernel - custom drive #15958
base: main
Are you sure you want to change the base?
Fix opening active notebook from kernel - custom drive #15958
Conversation
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
I've noticed that localPath is intentionally used for the session creation. Is there a specific reason for this? |
Thank you! The test failure appears related, if this change is indeed desired we should update the the tests too:
|
The change does look reasonable indeed. As originally noticed in jupyterlite/jupyterlite#1227 there were some changes in JupyterLab 4 when it comes to the handling of these paths. Which led to this comment: #14519 (comment) Looks like it was needed for the collaboration extension, although not sure why exactly. It could be because the collaboration drive replaces the default file browser. |
Trying from the Binder for this PR (which has |
@jtpio, I've tried opening the console via 'New Console for Notebook,' where it prompts to select a kernel. Upon choosing the notebook's kernel, the console opens with that selection as expected. open-console.mp4 |
@itsmevichu normally the expected behavior is the same kernel being reused for both the notebook and the console: jupyterlab-new-console-for-notebook.webm |
@itsmevichu how's it going here? It looks like this PR will solve this issue on jupyter-collaboration. 🚀 I was planning to work on PR but saw you had started one. Great work! I'm happy to help test and review going forward. I also see the regression @jtpio mentioned when opening a console from a previous session when testing your PR. Let us know if you have questions here to push this PR through. Thanks! |
@jtpio I think this is may be caused by jupyter-collaboration's replacement of the file browser, because I only see this behavior when jupyter-collaboration is installed (I tested this PR locally with + without JC). |
Thanks @Zsailer for looking into this!
OK so if this PR fixes the default install (without RTC), maybe we can look into fixing this in |
@Zsailer following up here, what do you think we should do here? |
Fixes #15931