Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker-compose): specify pull_policy for hyperswitch services #4688

Merged
merged 3 commits into from
May 20, 2024

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds a pull_policy field for hyperswitch services in the Docker Compose setup, so that the latest images are pulled from Docker Hub. In addition, this PR renames the analytics profile in the Docker Compose to olap, and moves the fluentd, opensearch and opensearch-dashboards services under the olap profile.

Motivation and Context

This would ensure that the latest images from Docker Hub are pulled and run, even if the user has old images cached on their local system.

How did you test it?

Running the Docker Compose setup locally with docker compose up -d and docker compose --profile olap up -d and verified that the intended containers come up.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 17, 2024
@SanchithHegde SanchithHegde added this to the May 2024 Release milestone May 17, 2024
@SanchithHegde SanchithHegde self-assigned this May 17, 2024
@SanchithHegde SanchithHegde requested review from a team as code owners May 17, 2024 13:27
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 909e75c May 20, 2024
12 of 13 checks passed
@Gnanasundari24 Gnanasundari24 deleted the docker-compose-pull-policy branch May 20, 2024 13:15
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants