Tweaks for serialization of DTypePolicy in ops/layers. #19728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Subclasses of `Operation` / `Layer` which override `__init__` and use the `dtype` parameter don't expect a `dict`. We deserialize the `DTypePolicy` in `from_config`. - The auto `get_config` feature would break when a `DTypePolicy` was passed to the constructor of any `Operation` or `Layer` subclass not implementing `get_config`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19728 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 498 498
Lines 45757 45761 +4
Branches 8454 8456 +2
=======================================
+ Hits 35931 35935 +4
Misses 8091 8091
Partials 1735 1735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
mloc
added a commit
to mloc/keras
that referenced
this pull request
May 22, 2024
As of keras-team#19728, Operation.from_config() has been overriding the dtype field in the passed config dict. There doesn't seem to be an explicit contract that from_config doesn't modify the config argument, but this seems to be the case in practice, and this behaviour has broken some code on an internal repo.
fchollet
pushed a commit
that referenced
this pull request
May 22, 2024
As of #19728, Operation.from_config() has been overriding the dtype field in the passed config dict. There doesn't seem to be an explicit contract that from_config doesn't modify the config argument, but this seems to be the case in practice, and this behaviour has broken some code on an internal repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation/Layerwhich override__init__and use thedtypeparameter don't expect adict. We deserialize theDTypePolicyinfrom_config.get_configfeature would break when aDTypePolicywas passed to the constructor of anyOperationorLayersubclass not implementingget_config.