Thread safety #50
Open
Thread safety #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to improve thread safety for static methods that may be called from multiple threads. This change does not affect the thread safety of individual HttpRequest instances. Use ThreadLocal for trustedFactory, as the documentation for the classes used makes no thread- safety guarantees. Make TRUSTED_VERIFIER final and initialize lazily using the lazy initialization holder class idiom used in Effective Java item 71, as the implementation used is thread-safe. Make connectionFactory volatile. This requires implementers of the ConnectionFactory interface to ensure that their implementation is thread-safe. This also changes the static members used that were not final to use the more conventional camelCase naming rather than ALL_CAPS.
|
Hey, just wondering if there were any issues with this pull request. I'd be happy to address any issues. |
|
Nope, sorry for the delay, will merge it soon. Do you think it is feasible to add any tests for this that will prove these changes are needed? |
|
hey folks, what are the odds of getting this merged in? |
|
@rferreira are you having threading issues using this library? |
|
@kevinsawicki nope, just a small false alarm a few weeks back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve thread safety for static methods that may be called from multiple threads.
This change does not affect the thread safety of individual HttpRequest instances.
Use ThreadLocal for trustedFactory, as the documentation for the classes used makes no thread-
safety guarantees.
Make TRUSTED_VERIFIER final and initialize lazily using the lazy initialization holder class
idiom used in Effective Java item 71, as the implementation used is thread-safe.
Make connectionFactory volatile. This requires implementers of the ConnectionFactory interface
to ensure that their implementation is thread-safe.
This also changes the static members used that were not final to use the more conventional
camelCase naming rather than ALL_CAPS.