fix: Updated ember-gesture-modifiers to ^5.0.0 #186
Conversation
|
Thanks @cah-yu-yuan. Letting the tests run, once they are green I'll merge and release. If I forget, please ping me. |
|
Not really sure what the problem even is with the tests, but I think it might be with ember-try. See ember-cli/ember-try#912. There is a release 3.0.0-beta.1 |
|
Anyway to kick off the tests on main? Wonder when the last time they worked was. Sorry to cause you more work for such a simple change |
|
Going to fix it here, I'm sure the issue probably exists on main. Most of my work has been mostly in #174 but that's still a bit away from being finished. |
|
In no rush for the PR. Still waiting on a couple other addons to expand the ember-modifer version. Was just trying to help. Will wait. Thanks for all your efforts |
|
Do you need ember 3.24 support or is 3.28 fine? |
|
We are on 4.11 |
|
@cah-yu-yuan could you rebase? I can merge and release this after that. |
cah-yu-yuan
force-pushed
the
ember-gesture-modifiers
branch
from
3d26514
to
1276daa
Compare
|
This has been rebased, please approve the workflow |
|
Looks like an error |
|
I wonder if this should have been a 3 || 4 || 5 type of thing. My guess is the CI all say node 14. A lot of things are now requiring 16 min. We have 18 or 20 local which is probably why all the tests pass locally. Should Yu update the CI? or should that be a you thing? OR.... should we update the CI in a separate Pr then rebase Yu's PR |
|
I'll update the CI. Thanks for looking into it! |
knownasilya
changed the title
|
Hum, I updated master but still seeing the error. Will try to give it more of a look tomorrow. |
Fixes #185