Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the processed body/files #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

techanon
Copy link

@techanon techanon commented May 2, 2017

This change exposes the resulting request body and/or files value to the outer Koa wrapper for each respective object.

This change exposes the resulting request body and/or files value to the outer Koa wrapper for each respective object.
techborn and others added 3 commits May 2, 2017 13:11
Changed the engine requirements to coordinate with Koa 2.x's requirements of Node 6 or newer.
@techanon
Copy link
Author

techanon commented May 2, 2017

The tests pass on node 6.x and newer (as per what Koa 2.x requires).

Changed node versions that are tested since Koa 2.x only requires Node 6 or greater.
@i5ting
Copy link
Contributor

i5ting commented May 16, 2017

can be use ctx.files ?

@i5ting
Copy link
Contributor

i5ting commented May 16, 2017

@fundon

@i5ting
Copy link
Contributor

i5ting commented May 16, 2017

@techborn thanks

@fabiob
Copy link

fabiob commented Aug 30, 2017

Will this PR be merged soon?

@fundon
Copy link
Member

fundon commented May 7, 2018

@techborn Dont add ;, plz.

@niftylettuce
Copy link

@fundon I can fix this and get it published if you give me collab

@@ -39,7 +39,10 @@ function makePromise(multer, name) {
if ('request' in ctx){
if (ctx.req.body) ctx.request.body = ctx.req.body;
if (ctx.req.file) ctx.request.file = ctx.req.file;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be ctx.file.

@niftylettuce
Copy link

Please see my comment at #30 (comment) and close this issue. The official Koa organization has forked this repository and released it (with PR's merged) under @koajs/multer. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants