core: bump packaging dep to v24 #21142
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:XS
| @@ -15,7 +15,7 @@ langsmith = "^0.1.0" | |||
| tenacity = "^8.1.0" | |||
| jsonpatch = "^1.33" | |||
| PyYAML = ">=5.3" | |||
| packaging = "^23.2" | |||
| packaging = ">=23.2,^24.0" | |||
There was a problem hiding this comment.
>=23.2 implies 24 and 25 if i'm not mistaken?
There was a problem hiding this comment.
>= equal or higher than.
AFAIK this implies higher than or equal to 23.2 and lower than 25.
Ref: https://python-poetry.org/docs/dependency-specification/
There was a problem hiding this comment.
afaik the , indicates a logical AND not a logical OR, so >=23.2,^24.0 ends up just being ^24.0. should it isntead be >=23.2,<25?
dosubot
bot
added
the
lgtm
|
Thanks! We'll try to see if we can remove packaging as a dependency to avoid dependency conflicts for users |
Head branch was pushed to by a user without write access
dokterbob
force-pushed
the
bump_packaging_v24
branch
from
ed4caf1
to
929f241
Compare
That's great to hear but in the mean time, perhaps we could use my code to fix the issue for the time being? Just rebased my PR to master. |
Allow installing core with packaging@^24.