Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc list not empty #21208

Merged
merged 16 commits into from
May 20, 2024
Merged

doc list not empty #21208

merged 16 commits into from
May 20, 2024

Conversation

WilliamEspegren
Copy link
Contributor

Make sure the doc list is not empty, and set Metadata: true in param, to enable the user to disable metadata for slightly faster crawls.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 10:18am

@WilliamEspegren WilliamEspegren marked this pull request as ready for review May 2, 2024 16:05
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels May 2, 2024
@WilliamEspegren
Copy link
Contributor Author

@eyurtsev anything blocking this?

@WilliamEspegren
Copy link
Contributor Author

@eyurtsev Just mention me if something doesn't add up :)

@WilliamEspegren
Copy link
Contributor Author

@eyurtsev ready to merge :)

@WilliamEspegren
Copy link
Contributor Author

@hwchase17 I think this is ready to merge now, thank you for noticing the unnecessary check

@hwchase17 hwchase17 merged commit 30bca57 into langchain-ai:master May 20, 2024
41 checks passed
jeromechoo pushed a commit to jeromechoo/langchain that referenced this pull request May 20, 2024
Make sure the doc list is not empty, and set Metadata: true in param, to
enable the user to disable metadata for slightly faster crawls.
JuHyung-Son pushed a commit to JuHyung-Son/langchain that referenced this pull request May 23, 2024
Make sure the doc list is not empty, and set Metadata: true in param, to
enable the user to disable metadata for slightly faster crawls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants