-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc list not empty #21208
Merged
Merged
doc list not empty #21208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
Ɑ: doc loader
Related to document loader module (not documentation)
🤖:improvement
Medium size change to existing code to handle new use-cases
labels
May 2, 2024
eyurtsev
reviewed
May 2, 2024
@eyurtsev anything blocking this? |
@eyurtsev Just mention me if something doesn't add up :) |
@eyurtsev ready to merge :) |
hwchase17
reviewed
May 16, 2024
@hwchase17 I think this is ready to merge now, thank you for noticing the unnecessary check |
jeromechoo
pushed a commit
to jeromechoo/langchain
that referenced
this pull request
May 20, 2024
Make sure the doc list is not empty, and set Metadata: true in param, to enable the user to disable metadata for slightly faster crawls.
JuHyung-Son
pushed a commit
to JuHyung-Son/langchain
that referenced
this pull request
May 23, 2024
Make sure the doc list is not empty, and set Metadata: true in param, to enable the user to disable metadata for slightly faster crawls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ɑ: doc loader
Related to document loader module (not documentation)
🤖:improvement
Medium size change to existing code to handle new use-cases
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the doc list is not empty, and set Metadata: true in param, to enable the user to disable metadata for slightly faster crawls.