partners: Remove unnecessary print from voyageai embeddings #21865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new voyageai text_embeddings model: voyage-large-2-instruct
Remove unnecessary print
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
ccurme
approved these changes
May 18, 2024
| @@ -45,7 +45,6 @@ def default_values(cls, values: dict) -> dict: | |||
| model = values.get("model") | |||
| batch_size = values.get("batch_size") | |||
| if batch_size is None: | |||
| print("batch size", batch_size) | |||
There was a problem hiding this comment.
we import a logger in this module, should we emit the batch size with the logger?
dosubot
bot
added
the
lgtm
jeromechoo
pushed a commit
to jeromechoo/langchain
that referenced
this pull request
May 20, 2024
…n-ai#21865) Thank you for contributing to LangChain! Remove unnecessary print from voyageai embeddings - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.
JuHyung-Son
pushed a commit
to JuHyung-Son/langchain
that referenced
this pull request
May 23, 2024
…n-ai#21865) Thank you for contributing to LangChain! Remove unnecessary print from voyageai embeddings - [x] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Remove unnecessary print from voyageai embeddings
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.