Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Update voyage.ts to pass input_type (default null, or query or document) #5456

Closed
wants to merge 5 commits into from

Conversation

nicolas-geysse
Copy link
Contributor

Fixes # (issue)
Improve embedding quality

Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 9:07pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 20, 2024 9:07pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels May 18, 2024
If you delete the input: text, you may not pass any text to the embedding.
@jacoblee93 jacoblee93 changed the title Update voyage.ts to pass input_type (default null, or query or document) community[patch]: Update voyage.ts to pass input_type (default null, or query or document) May 20, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label May 20, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@nicolas-geysse
Copy link
Contributor Author

You're very welcome !
I just realized that I may have forgotten to commit here
libs/langchain-community/src/embeddings/tests/voyage.int.test.ts
and here
docs/core_docs/docs/integrations/text_embedding/voyageai.mdx
I just commit for this new files, but as I'm a total noob with Github, I don't know where has been pushed these new modifications. (can you see them ???)

@jacoblee93
Copy link
Collaborator

You're very welcome ! I just realized that I may have forgotten to commit here libs/langchain-community/src/embeddings/tests/voyage.int.test.ts and here docs/core_docs/docs/integrations/text_embedding/voyageai.mdx I just commit for this new files, but as I'm a total noob with Github, I don't know where has been pushed these new modifications. (can you see them ???)

Ah, no that doesn't seem to be on this PR. It seems reasonable but feel free to push if you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants