Small fix in getEvents.py #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marthaisabelhilton
changed the title
|
Hello, this script wasn't working for me out of the box so I made a small change. Can someone please check and merge? |
vlukashenko
reviewed
Nov 23, 2021
| @@ -94,7 +94,7 @@ if __name__ == '__main__': | |||
| files = FILES[:n_files] | |||
| for f in files: | |||
| print('Getting file {0}.'.format(f)) | |||
| call('dirac-dms-get-file {0}'.format(f), shell=True) | |||
| call('lb-dirac dirac-dms-get-file LFN:{0}'.format(f), shell=True) | |||
There was a problem hiding this comment.
Hi, Martha! Thanks for looking into the lesson! I think if you do this, then the following lb-dirac python getEntries.py [n] command will not work. Also LFN: or no LFN: would depend on the names you provide in the script. I would keep without LFN:, since the .DST.py file that students download during the previous bkk lesson has string with LFN: as part of the name.
The normal code works for me now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.