dragonfly: disable SO_REUSEPORT for UDP socket bindings #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Signed-off-by: Andy Pan <i@andypan.me>
|
LGTM, can you please extend the commend above the code which mentions this in the context of Linux? |
--------- Signed-off-by: Andy Pan <i@andypan.me>
|
One more thing,
Done! |
saghul
approved these changes
May 17, 2024
--------- Signed-off-by: Andy Pan <i@andypan.me>
|
I think this PR is good to go? |
|
Yes, can you please squash the commits? |
|
I thought you could squash commits when merging a GitHub PR? |
|
You're right. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't enable SO_REUSEPORT on
DragonflyBSDbecause that socket option has different semantics from other *BSD: it shares the port rather than steals it.