unix: use the presence of SOCK_* instead of OS macros for socketpair #4413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stuffing
SOCK_NONBLOCK
andSOCK_CLOEXEC
into thetype
argument when callingsocketpair()
is widely supported across UNIX-like OS: Linux, BSD, Solaris, etc., as is thesocket()
.socket()
andsocketpair()
share the SOCK_ flags under the hood.Currently, we detect the presence of
SOCK_NONBLOCK
andSOCK_CLOEXEC
forsocket()
:libuv/src/unix/core.c
Lines 494 to 499 in bf61390
while checking the specific OS macros for
socketpair()
. We keep them in sync to expand the scope of SOCK_* flags forsocketpair()
.References