Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: feat(import): add clickup import #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

draft: feat(import): add clickup import #220

wants to merge 3 commits into from

Conversation

de-ar
Copy link

@de-ar de-ar commented Oct 10, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022 •
edited

⚠️ No Changeset found

Latest commit: f8b0c5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@de-ar de-ar mentioned this pull request Oct 10, 2022
Closed
@robcurtis
Copy link

Is this PR getting merged soon? We're interested in moving over from Clickup.

@de-ar
Copy link
Author

de-ar commented Feb 11, 2023

Earlier I could not test the ClickUp importer. Right now, I'm busy at some other work. So no chance of it being merged anytime soon.

@Chew
Copy link

Chew commented Jun 15, 2023

Is there any updates, or do you intend to make some? I'd love to take over otherwise (will credit you as the starting point)

@de-ar
Copy link
Author

de-ar commented Jun 15, 2023

Hey @Chew!
I do intend to make updates, but my time has become limited. Please do take over and I'm here if you have any questions at all.

@Chew Chew mentioned this pull request Jun 15, 2023
Draft
akashchouhan16
akashchouhan16 suggested changes Jun 27, 2023
View reviewed changes
package.json
@@ -1,38 +1,78 @@
{
"name": "linear",
"private": true,
"author": "Linear Orbit, Inc",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on this line is not relevant to the PR, could keep it as it was previously.

package.json
"build:import": "lerna run build:import",
"build:sdk": "lerna run build:sdk",
"build:types": "npx tsc --project tsconfig.check.json",
"build": "run-s generate build:sdk generate:test build:import build:types docs",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise for this line too. Not relevant to the proposed change in this PR.

packages/import/package.json
"main": "dist/index-cjs.min.js",
"module": "dist/index-es.min.js",
"types": "dist/index.d.ts",
"bin": {
"linear-import": "bin/linear-import.js"
},
"repository": "https://github.com/linear/linear",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a relevant code change

packages/import/src/importers/clickupCsv/ClickupCsvImporter.ts
Medium: 3,
Low: 4,
};
return priorityMap[input] || 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashchouhan16 akashchouhan16 akashchouhan16 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@de-ar @robcurtis @Chew @akashchouhan16