Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making edge compatible #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

morgs32
Copy link

@morgs32 morgs32 commented Jul 17, 2023

Please don't take this too seriously. I wanted to make this compatible with nextjs middleware so I took a very brute force approach in my fork. I grabbed the bunchee build setup from the swr repo so as to not have to think at all about rollup. I used crypto-js for webhook verification (when there's probably a way to do it with crypto.subtle?). The sdk doesn't build if you have installed node_modules at the root. Altogether a lazy approach. Just putting it on your radar. Feel free to shake your head and close this!

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: a6916ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@guillaumelachaud
Copy link
Contributor

guillaumelachaud commented Jul 17, 2023

Hi!

It looks like there's a bunch of things that don't work anymore with regards to Github Actions and the repo's automation, that we will need to keep. I don't think we will be able to accept the PR as-is, but at least it puts the edge compatibility on our radar, thanks!

I have filed an issue internally to keep track of this and will have a look this week to get a sense of feasibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants