[LBSD-2786] - Complete Instance Settings UI #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Completes the implementation of the UI to manage Instance Settings. This UI is restricted only to users that have the
is_support
attribute active. If the attribute is not active, then the UI is not visible.What has changed
Instance Admin
role in favour of usingis_support
attribute insteadis_support
attributeis_support
enabledmerge_config
method to keep it simple for now. In the future we can analyse if a more complex approach is neededSteps to test
Thanks for reviewing!
Resolves: LBSD-2786