-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /refresh to update sources and some configurations #1179
base: main
Are you sure you want to change the base?
Add /refresh to update sources and some configurations #1179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a good start, thanks! I will have to think of how to test this best - perhaps add a new shell script test-watch.sh
that is similar to existing test.sh
, except that it will:
- start martin with
--auto-bounds skip
(so that it starts faster) - wait for it to start
- get a catalog into catalog1.json
- use
psql
to create a new table and a function, and possibly make some other modifications like deleting something else - use
curl
toPOST
a refresh command to some Martin's endpoint that triggers the refresh - I guess this request should not return until refresh is done? Make sure to have some global "refresh lock" to avoid multiple simultaneous refresh requests? - get another catalog saving it to catalog2.txt
The existing bless/diff setup will check that the catalog results are as expected
Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>
Some ways to push this forward? |
I'm trying to keep going on this. |
There is a well known dashmap crate that essentially functions as a concurrent hashmap (i.e. replaces |
And should we keep the |
lets implement
|
94365d7
to
7440428
Compare
Seems it's almost there? Will fix the tests and update doc later. |
Weired. That shouldn't fail. CI / Build and test docker images
The source
|
8bbd55f
to
c0a1700
Compare
There must be a lot to clean up. |
/catalog
Try to fix #288
/refresh
to endpoint(read and merge config and flush the cache)