Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few small fixes for rubyspecs #192

Merged
merged 6 commits into from
Mar 5, 2024
Merged

A few small fixes for rubyspecs #192

merged 6 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. A few small fixes for rubyspecs 

    * Size error cases
* Enumerator.product rejects kwargs by name
* Product#rewind rewinds in "direct order", not reverse
    @headius
    headius committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    3901db0 View commit details
    Browse the repository at this point in the history

  2. Update lib/backports/3.2.0/enumerator/product.rb 

    Let's not go out of our way to return senseless results.
See ruby/spec#1140
    @marcandre
    marcandre committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4f5b6db View commit details
    Browse the repository at this point in the history

  3. Satisfy rubocop

    @marcandre
    marcandre committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0189573 View commit details
    Browse the repository at this point in the history

  4. Satisfy rubocop

    @marcandre
    marcandre committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d7caa14 View commit details
    Browse the repository at this point in the history

  5. Update lib/backports/3.2.0/enumerator/product.rb

    @marcandre
    marcandre committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f7d423d View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Satisfy rubocop
    @marcandre
    marcandre committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    816174a View commit details
    Browse the repository at this point in the history